qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Cc: "Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
	"Oliver Hartkopp A" <socketcan@hartkopp.net>,
	jinyang.sia@gmail.com,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	rtems-devel@rtems.org, "Stefan Weil" <sw@weilnetz.de>,
	linux-can@vger.kernel.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 0/2] CAN SJA100 controller emulation and SocketCAN based host CAN bus access
Date: Fri, 23 May 2014 11:42:25 +0200	[thread overview]
Message-ID: <20140523094225.GA1260@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <201405151553.07872.pisa@cmp.felk.cvut.cz>

On Thu, May 15, 2014 at 03:53:07PM +0200, Pavel Pisa wrote:
> The decisions for further development
> 
> Should be minimal working solution included in the QEMU
> mainline in short term?
> (months .. or rather wait for agreement on final
> infrastructure, may be years because of our other load
> and complexity of full model task)
> 
> Is preferred approach to open CAN QEMU fork on GitHub?
> Etc...

It sounds like there is doubt about whether anyone has enough time to
implement CAN more fully.  I'm not thrilled about reviewing patches if
it's a partial implementation with few end users - something like that
can be kept out-of-tree until someone with enough resources can polish
it and push it upstream.

A few more comments about the network subsystem:

The QEMU network subsystem doesn't emulate Ethernet.  It's just a way to
connect an emulated NIC with a host netdev (tap, socket, etc) with a few
extra services like link down/up, flow control, etc.

In the CAN world it would connect a CAN controller (e.g. Kvaser PCI)
with a host device (e.g. using libcan or whatever).  I don't think it's
necessary to emulate bus arbitration in this model, that should happen
via the host device (which is talking to an real CAN bus).

The question is whether the network subsystem's send/receive model works
or whether you need something CAN-specific like publishing RX/TX objects
along with their metadata (IDs, priorities, deadlines, etc).  That would
be a major difference and it would probably make sense it implement it
as a separate subsystem.

Stefan

  parent reply	other threads:[~2014-05-23  9:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 18:10 [Qemu-devel] [PATCH 0/2] CAN SJA100 controller emulation and SocketCAN based host CAN bus access Pavel Pisa
2014-05-09 18:14 ` [Qemu-devel] [PATCH 1/2] CAN bus simple SJA1000 PCI card emulation for QEMU Pavel Pisa
2014-05-12  9:01   ` Peter Crosthwaite
2014-05-12  9:18     ` Andreas Färber
2014-05-09 18:15 ` [Qemu-devel] [PATCH 2/2] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added Pavel Pisa
2014-05-13 12:29 ` [Qemu-devel] [PATCH 0/2] CAN SJA100 controller emulation and SocketCAN based host CAN bus access Stefan Hajnoczi
2014-05-15 13:53   ` Pavel Pisa
2014-05-23  1:52     ` [Qemu-devel] " jinyang.sia
2014-05-23  9:42     ` Stefan Hajnoczi [this message]
2014-05-23 14:25       ` [Qemu-devel] [PATCH 0/2] " Pavel Pisa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140523094225.GA1260@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=afaerber@suse.de \
    --cc=jinyang.sia@gmail.com \
    --cc=linux-can@vger.kernel.org \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=pisa@cmp.felk.cvut.cz \
    --cc=qemu-devel@nongnu.org \
    --cc=rtems-devel@rtems.org \
    --cc=socketcan@hartkopp.net \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).