From: Stefan Hajnoczi <stefanha@gmail.com>
To: Hani Benhabiles <kroosec@gmail.com>
Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com,
qemu-devel@nongnu.org, lcapitulino@redhat.com,
stefanha@redhat.com, imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH 6/7] monitor: Add host_net_remove arguments completion.
Date: Fri, 23 May 2014 14:09:06 +0200 [thread overview]
Message-ID: <20140523120906.GE1260@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1400540600-1328-7-git-send-email-kroosec@gmail.com>
On Tue, May 20, 2014 at 12:03:19AM +0100, Hani Benhabiles wrote:
> Relies on readline unique completion strings patch to make the added vlan/hub
> completion values unique, instead of using something like a hash table.
>
> Signed-off-by: Hani Benhabiles <hani@linux.com>
> ---
> hmp-commands.hx | 1 +
> hmp.h | 2 ++
> monitor.c | 38 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 41 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2014-05-23 12:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 23:03 [Qemu-devel] monitor: Command completion for various commands Hani Benhabiles
2014-05-19 23:03 ` [Qemu-devel] [PATCH 1/7] monitor: Add ringbuf_write and ringbuf_read argument completion Hani Benhabiles
2014-05-19 23:03 ` [Qemu-devel] [PATCH 2/7] monitor: Add watchdog_action " Hani Benhabiles
2014-05-19 23:03 ` [Qemu-devel] [PATCH 3/7] monitor: Add migrate_set_capability completion Hani Benhabiles
2014-05-21 18:42 ` Dr. David Alan Gilbert
2014-05-22 7:05 ` Markus Armbruster
2014-05-19 23:03 ` [Qemu-devel] [PATCH 4/7] monitor: Add host_net_add device argument completion Hani Benhabiles
2014-05-23 12:05 ` Stefan Hajnoczi
2014-05-25 16:12 ` Hani Benhabiles
2014-05-26 9:20 ` Stefan Hajnoczi
2014-05-19 23:03 ` [Qemu-devel] [PATCH 5/7] readline: Make completion strings always unique Hani Benhabiles
2014-05-19 23:03 ` [Qemu-devel] [PATCH 6/7] monitor: Add host_net_remove arguments completion Hani Benhabiles
2014-05-23 12:09 ` Stefan Hajnoczi [this message]
2014-05-19 23:03 ` [Qemu-devel] [PATCH 7/7] monitor: Add delvm and loadvm argument completion Hani Benhabiles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523120906.GE1260@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=imammedo@redhat.com \
--cc=kroosec@gmail.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).