From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnoV7-0001rX-G3 for qemu-devel@nongnu.org; Fri, 23 May 2014 08:23:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnoV1-0005Mi-Hv for qemu-devel@nongnu.org; Fri, 23 May 2014 08:23:05 -0400 Received: from mail-ee0-x231.google.com ([2a00:1450:4013:c00::231]:51446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnoV1-0005MU-3I for qemu-devel@nongnu.org; Fri, 23 May 2014 08:22:59 -0400 Received: by mail-ee0-f49.google.com with SMTP id e53so3605824eek.36 for ; Fri, 23 May 2014 05:22:58 -0700 (PDT) Date: Fri, 23 May 2014 14:09:06 +0200 From: Stefan Hajnoczi Message-ID: <20140523120906.GE1260@stefanha-thinkpad.redhat.com> References: <1400540600-1328-1-git-send-email-kroosec@gmail.com> <1400540600-1328-7-git-send-email-kroosec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400540600-1328-7-git-send-email-kroosec@gmail.com> Subject: Re: [Qemu-devel] [PATCH 6/7] monitor: Add host_net_remove arguments completion. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hani Benhabiles Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@redhat.com, imammedo@redhat.com On Tue, May 20, 2014 at 12:03:19AM +0100, Hani Benhabiles wrote: > Relies on readline unique completion strings patch to make the added vlan/hub > completion values unique, instead of using something like a hash table. > > Signed-off-by: Hani Benhabiles > --- > hmp-commands.hx | 1 + > hmp.h | 2 ++ > monitor.c | 38 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 41 insertions(+) Reviewed-by: Stefan Hajnoczi