Re: [Qemu-devel] [PATCH v2 8/8] block: Drop redundant bdrv_refresh_limits

[Jeff Cody <jcody@redhat.com>]

On Fri, May 23, 2014 at 09:29:48PM +0800, Fam Zheng wrote:
> The above bdrv_set_backing_hd already does this.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/block.c b/block.c
> index aa9b5ab..a517d72 100644
> --- a/block.c
> +++ b/block.c
> @@ -1182,9 +1182,6 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict *options, Error **errp)
>      }
>      bdrv_set_backing_hd(bs, backing_hd);
>  
> -    /* Recalculate the BlockLimits with the backing file */
> -    bdrv_refresh_limits(bs);
> -
>  free_exit:
>      g_free(backing_filename);
>      return ret;
> -- 
> 1.9.2
>

I think there is another redundant one in block/stream.c, in
close_unused_images().  But that doesn't affect this patch:

Reviewed-by: Jeff Cody <jcody@redhat.com>