From: Stefan Hajnoczi <stefanha@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org, mjt@mls.msk.ru
Subject: Re: [Qemu-devel] [PATCH 1/4] glib-compat.h: add new thread API emulation on top of pre-2.31 API
Date: Fri, 23 May 2014 17:24:00 +0200 [thread overview]
Message-ID: <20140523152400.GA29542@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <537F65B0.1020609@redhat.com>
On Fri, May 23, 2014 at 05:13:52PM +0200, Paolo Bonzini wrote:
> Il 23/05/2014 17:03, Stefan Hajnoczi ha scritto:
> >On Fri, May 23, 2014 at 01:44:54PM +0200, Paolo Bonzini wrote:
> >>+static inline gpointer do_g_cond_new(gpointer unused)
> >>+{
> >>+ return (gpointer) (gpointer) (gpointer) (gpointer) (gpointer) (gpointer) (gpointer) (gpointer) (gpointer) g_cond_new();
> >
> >what what what what what what what what what what what?
>
> I guess I fat-fingered an "i" into "9i"...
>
> Is this the only complaint? :)
I need to review it properly on Monday.
Stefan
next prev parent reply other threads:[~2014-05-23 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 11:44 [Qemu-devel] [PATCH 0/4] standalone libcacard Paolo Bonzini
2014-05-23 11:44 ` [Qemu-devel] [PATCH 1/4] glib-compat.h: add new thread API emulation on top of pre-2.31 API Paolo Bonzini
2014-05-23 15:03 ` Stefan Hajnoczi
2014-05-23 15:13 ` Paolo Bonzini
2014-05-23 15:24 ` Stefan Hajnoczi [this message]
2014-06-06 13:28 ` Stefan Hajnoczi
2014-05-23 11:44 ` [Qemu-devel] [PATCH 2/4] vscclient: use glib thread primitives not qemu Paolo Bonzini
2014-05-23 11:44 ` [Qemu-devel] [PATCH 3/4] libcacard: replace qemu thread primitives with glib ones Paolo Bonzini
2014-05-23 11:44 ` [Qemu-devel] [PATCH 4/4] libcacard: actually use symbols file Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523152400.GA29542@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=mjt@mls.msk.ru \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).