From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnrZq-0002Rf-VB for qemu-devel@nongnu.org; Fri, 23 May 2014 11:40:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnrZl-0005Fx-C1 for qemu-devel@nongnu.org; Fri, 23 May 2014 11:40:10 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:43666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnrZl-0005Dr-4A for qemu-devel@nongnu.org; Fri, 23 May 2014 11:40:05 -0400 Received: by mail-wi0-f180.google.com with SMTP id hi2so1099160wib.1 for ; Fri, 23 May 2014 08:40:04 -0700 (PDT) Date: Fri, 23 May 2014 17:40:01 +0200 From: Stefan Hajnoczi Message-ID: <20140523154001.GB29542@stefanha-thinkpad.redhat.com> References: <1400230826-18009-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400230826-18009-1-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 00/19] block: Purge qerror_report() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Fri, May 16, 2014 at 11:00:07AM +0200, Markus Armbruster wrote: > qerror_report() is a transitional interface to help with converting > existing HMP commands to QMP. It should not be used elsewhere. This > series purges it from the block subsystem. > > It is based on Fam's "[PATCH v19 00/16] Drop in_use from > BlockDriverState and enable point-in-time snapshot exporting over > NBD". > > v2: > * Trivial rebase > * Fix error propagation in PATCH 04 [Eric] > * More tasteful line breaks in PATCH 04 > * Indentation cleanup in PATCH 10 [Eric] > * Don't break sd_prealloc() in PATCH 14 [Eric] > * Fix error propagation in PATCH 17 > * New PATCH 18 to fix silent failures > > Markus Armbruster (19): > blockdev: Don't use qerror_report_err() in drive_init() > blockdev: Don't use qerror_report() in do_drive_del() > qemu-nbd: Don't use qerror_report() > block/rbd: Propagate errors to open and create methods > block/ssh: Drop superfluous libssh2_session_last_errno() calls > block/ssh: Propagate errors through check_host_key() > block/ssh: Propagate errors through authenticate() > block/ssh: Propagate errors through connect_to_ssh() > block/ssh: Propagate errors to open and create methods > block/vvfat: Propagate errors through enable_write_target() > block/vvfat: Propagate errors through init_directories() > block/sheepdog: Propagate errors through connect_to_sdog() > block/sheepdog: Propagate errors through get_sheep_fd() > block/sheepdog: Propagate errors through sd_prealloc() > block/sheepdog: Propagate errors through do_sd_create() > block/sheepdog: Propagate errors through find_vdi_name() > block/sheepdog: Propagate errors to open and create methods > block/sheepdog: Fix silent sd_open(), sd_create() failures > block/sheepdog: Don't use qerror_report() > > block/rbd.c | 71 ++++++++++++++------------ > block/sheepdog.c | 149 ++++++++++++++++++++++++++++++++++-------------------- > block/ssh.c | 151 +++++++++++++++++++++++++++++++++---------------------- > block/vvfat.c | 34 ++++++------- > blockdev.c | 7 ++- > qemu-nbd.c | 6 +-- > 6 files changed, 246 insertions(+), 172 deletions(-) > > -- > 1.8.1.4 > > Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan