From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43646)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Wor5A-0006vI-8i
	for qemu-devel@nongnu.org; Mon, 26 May 2014 05:20:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Wor54-0006Ht-4S
	for qemu-devel@nongnu.org; Mon, 26 May 2014 05:20:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17785)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Wor53-0006Hl-SX
	for qemu-devel@nongnu.org; Mon, 26 May 2014 05:20:30 -0400
Date: Mon, 26 May 2014 11:20:24 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140526092024.GA4017@stefanha-thinkpad.redhat.com>
References: <1400540600-1328-1-git-send-email-kroosec@gmail.com>
	<1400540600-1328-5-git-send-email-kroosec@gmail.com>
	<20140523120503.GD1260@stefanha-thinkpad.redhat.com>
	<20140525161255.GD3588@Inspiron-3521>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140525161255.GD3588@Inspiron-3521>
Subject: Re: [Qemu-devel] [PATCH 4/7] monitor: Add host_net_add device
 argument completion.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hani Benhabiles <kroosec@gmail.com>
Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, lcapitulino@redhat.com, imammedo@redhat.com

On Sun, May 25, 2014 at 05:12:55PM +0100, Hani Benhabiles wrote:
> On Fri, May 23, 2014 at 02:05:03PM +0200, Stefan Hajnoczi wrote:
> > On Tue, May 20, 2014 at 12:03:17AM +0100, Hani Benhabiles wrote:
> > > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > > index 919af6e..6aaec1b 100644
> > > --- a/hmp-commands.hx
> > > +++ b/hmp-commands.hx
> > > @@ -1209,9 +1209,10 @@ ETEXI
> > >      {
> > >          .name       = "host_net_add",
> > >          .args_type  = "device:s,opts:s?",
> > > -        .params     = "tap|user|socket|vde|netmap|dump [options]",
> > > +        .params     = "tap|user|socket|vde|bridge|dump [options]",
> > 
> > Why did you delete "netmap"?  I guess "bridge" should have been appended.
> > 
> 
> Because "netmap" fails the net_host_check_device() check:
> 
> (qemu) host_net_add user
> (qemu) host_net_add foooo
> invalid host network device foooo
> (qemu) host_net_add netmap
> invalid host network device netmap
> 
> Should "netmap" be added there ?

Probably because your QEMU was not built with (optional) netmap support.
It's primarily used on FreeBSD but there is Linux code as well:
https://code.google.com/p/netmap/

Stefan