From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wr1Q9-0001Sl-DT for qemu-devel@nongnu.org; Sun, 01 Jun 2014 04:47:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wr1Q3-00024W-8f for qemu-devel@nongnu.org; Sun, 01 Jun 2014 04:47:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wr1Q2-00024Q-VW for qemu-devel@nongnu.org; Sun, 01 Jun 2014 04:47:07 -0400 Date: Sun, 1 Jun 2014 11:47:29 +0300 From: "Michael S. Tsirkin" Message-ID: <20140601084729.GB21173@redhat.com> References: <1401593596-8953-1-git-send-email-somlo@cmu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1401593596-8953-1-git-send-email-somlo@cmu.edu> Subject: Re: [Qemu-devel] [PATCH v3 0/3] e1000: allow model/device_id selection on command line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: peter.crosthwaite@xilinx.com, romain@dolbeau.org, qemu-devel@nongnu.org, agraf@suse.de, stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de On Sat, May 31, 2014 at 11:33:13PM -0400, Gabriel L. Somlo wrote: > Allow selection of different card models from the qemu > command line, to better accomodate a wider range of guests. Looks good to me. If possible pls address a nit I noted in one of the patches. Besides that: Reviewed-by: Michael S. Tsirkin > New in v3: > > - 1/3 and 2/3 from v2 now merged into a single patch (1/3), with: > - s/TYPE_E1000/TYPE_E1000_BASE/ as suggested by Stefan > - improved QOM-ification as suggested by Peter Crosthwaite > > - *OPTIONAL* patch to remove stale support for 8257xx (see commit blurb > in patch 3/3 for details > (this can be squashed on top of 1/3, but I'm including it separately > here for clarity, and as an RFC). > > Thanks, > Gabriel > > > v2: > > - moved check for 8257x out of the way of QOM, as suggested by > Michael (patch 1/3) > > - resolved "Signed-off-by" misunderstanding and miscellaneous style > issues (patch 2/3) > > - modified e1000 test to check for all supported models, as suggested > by Andreas (patch 3/3). I used eepro100-test.c as an example for > this change. > > > Gabriel L. Somlo (3): > e1000: allow command-line selection of card model > tests: e1000: test additional device IDs > e1000: remove broken support for 82573L > > hw/net/e1000.c | 110 +++++++++++++++++++++++++++++++++++++++------------- > hw/net/e1000_regs.h | 6 +++ > tests/e1000-test.c | 33 ++++++++++++---- > 3 files changed, 114 insertions(+), 35 deletions(-) > > -- > 1.9.3