From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38261)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1WrQpO-0002qd-Rd
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 07:55:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1WrQpG-0004of-Eo
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 07:54:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12128)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1WrQpG-0004nm-75
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 07:54:50 -0400
Date: Mon, 2 Jun 2014 12:54:45 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20140602115445.GF28039@redhat.com>
References: <1401709825-32579-1-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1401709825-32579-1-git-send-email-kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] gtk: cleanup backend dependencies
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Richard Henderson <rth@twiddle.net>

On Mon, Jun 02, 2014 at 01:50:25PM +0200, Gerd Hoffmann wrote:
> Make configure detect gtk x11 backend and link libX11 then.  Make
> gtk backend specific code properly #ifdef'ed on the GTK_WINDOWING_*
> backends at runtime).  Our gtk ui code should build and run fine on
> any platform now.
> 
> This also fixes the linker failute due to the new XkbGetKeyboard call
> added by commit 3158a3482b0093e41f2b2596fba50774ea31ae08.
> 
> Cc: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  configure |  4 +++
>  ui/gtk.c  | 97 ++++++++++++++++++++++++++++++++++++---------------------------
>  2 files changed, 60 insertions(+), 41 deletions(-)

Looks good.

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|