From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39244)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WrQtb-0005Kq-Gp
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 07:59:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WrQtV-0006QH-CJ
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 07:59:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52951)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WrQtV-0006Px-40
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 07:59:13 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s52BxBWd028326
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 2 Jun 2014 07:59:11 -0400
Date: Mon, 2 Jun 2014 13:59:09 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140602115909.GB4045@noname.str.redhat.com>
References: <1401564810-18798-1-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1401564810-18798-1-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-img: Report error even with
	--oformat=json
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Federico Simoncelli <fsimonce@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 31.05.2014 um 21:33 hat Max Reitz geschrieben:
> img_check() should report that the format of the given image does not
> support checks even if JSON output is desired. JSON data is output to
> stdout, as opposed to error messages, which are (in the case of
> qemu-img) printed to stderr. Therefore, it is easy to distinguish
> between the two.
> 
> Also, img_info() does already use error_report() for human-readable
> messages even though JSON output is desired (through
> collect_image_info_list()).
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>

Thanks, applied to the block branch.

Kevin