From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc: peter.crosthwaite@xilinx.com, romain@dolbeau.org, mst@redhat.com,
agraf@suse.de, qemu-devel@nongnu.org, stefanha@redhat.com,
pbonzini@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v3 1/3] e1000: allow command-line selection of card model
Date: Mon, 2 Jun 2014 14:25:52 +0200 [thread overview]
Message-ID: <20140602122552.GB3049@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1401593596-8953-2-git-send-email-somlo@cmu.edu>
On Sat, May 31, 2014 at 11:33:14PM -0400, Gabriel L. Somlo wrote:
> @@ -151,10 +141,21 @@ typedef struct E1000State_st {
> uint32_t compat_flags;
> } E1000State;
>
> -#define TYPE_E1000 "e1000"
> +typedef struct E1000DeviceClass {
The QOM type is called TYPE_E1000_BASE ("e1000-base"), please name this
E1000BaseClass. The reasoning is the same as my previous request for
consistent naming. Other QOM class users in hw/ also follow this
pattern (type "X", class "XClass").
next prev parent reply other threads:[~2014-06-02 12:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401593596-8953-1-git-send-email-somlo@cmu.edu>
2014-06-01 8:47 ` [Qemu-devel] [PATCH v3 0/3] e1000: allow model/device_id selection on command line Michael S. Tsirkin
2014-06-01 9:32 ` Peter Crosthwaite
[not found] ` <1401593596-8953-2-git-send-email-somlo@cmu.edu>
2014-06-01 8:46 ` [Qemu-devel] [PATCH v3 1/3] e1000: allow command-line selection of card model Michael S. Tsirkin
2014-06-01 9:18 ` Peter Crosthwaite
2014-06-02 12:25 ` Stefan Hajnoczi [this message]
[not found] ` <1401593596-8953-4-git-send-email-somlo@cmu.edu>
2014-06-01 9:25 ` [Qemu-devel] [PATCH v3 3/3] e1000: remove broken support for 82573L Peter Crosthwaite
2014-06-02 12:26 ` Stefan Hajnoczi
[not found] ` <1401593596-8953-3-git-send-email-somlo@cmu.edu>
2014-06-01 9:24 ` [Qemu-devel] [PATCH v3 2/3] tests: e1000: test additional device IDs Peter Crosthwaite
2014-06-02 12:27 ` Stefan Hajnoczi
2014-06-02 12:28 ` [Qemu-devel] [PATCH v3 0/3] e1000: allow model/device_id selection on command line Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602122552.GB3049@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=gsomlo@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=romain@dolbeau.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).