From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrRKK-0000sj-Cg for qemu-devel@nongnu.org; Mon, 02 Jun 2014 08:27:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrRKF-0001Ff-9X for qemu-devel@nongnu.org; Mon, 02 Jun 2014 08:26:56 -0400 Received: from mail-we0-x233.google.com ([2a00:1450:400c:c03::233]:56647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrRKF-0001Eb-38 for qemu-devel@nongnu.org; Mon, 02 Jun 2014 08:26:51 -0400 Received: by mail-we0-f179.google.com with SMTP id q59so4945665wes.24 for ; Mon, 02 Jun 2014 05:26:50 -0700 (PDT) Date: Mon, 2 Jun 2014 14:26:47 +0200 From: Stefan Hajnoczi Message-ID: <20140602122647.GC3049@stefanha-thinkpad.redhat.com> References: <1401593596-8953-1-git-send-email-somlo@cmu.edu> <1401593596-8953-4-git-send-email-somlo@cmu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1401593596-8953-4-git-send-email-somlo@cmu.edu> Subject: Re: [Qemu-devel] [PATCH v3 3/3] e1000: remove broken support for 82573L List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: peter.crosthwaite@xilinx.com, romain@dolbeau.org, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de On Sat, May 31, 2014 at 11:33:16PM -0400, Gabriel L. Somlo wrote: > Currently, e1000 support is based on the manual for the 8254xx > model series. 82573x models are documented in a separate manual > (see http://www.intel.com/content/dam/www/public/us/en/documents/manuals/pcie-gbe-controllers-open-source-manual.pdf) > and the 82573L device ID no longer works correctly on either Linux > (3.14.*) or Windows 7. > > This patch removes stale code claiming to support 82573L, cleaning > up the code base for the remaining 8254xx model series. > > Signed-off-by: Gabriel Somlo > --- > hw/net/e1000.c | 18 ------------------ > tests/e1000-test.c | 1 - > 2 files changed, 19 deletions(-) Reviewed-by: Stefan Hajnoczi