qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Benoît Canet" <benoit.canet@irqsave.net>,
	qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
	pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 0/5] qemu-iotests: Test case for IO throttling
Date: Mon, 2 Jun 2014 15:41:48 +0200	[thread overview]
Message-ID: <20140602134148.GH3049@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1392100862-25943-1-git-send-email-famz@redhat.com>

On Tue, Feb 11, 2014 at 02:40:57PM +0800, Fam Zheng wrote:
> This series adds iotest case for IO throttling.
> 
> There is a change in qemu-io sub-commands "aio_read" and "aio_write", which
> makes the aio requests accounted and the statistics reflected in blockstats.
> 
> Note that IO throttling implementation allows overcommiting of requests, so the
> actual IO happened in a time unit may be a bit larger than given limits. In the
> test case, the stats numbers are compared against 110%, to make room for such
> flexibility in order to improve determinism.
> 
> v3: Address comments from Benoît. (Thanks for the review!)
> 
>     [02/05] qtest: Add scripts/qtest/qtest.py
>             Fix comments.
>             Fix socket close order.
>             Removed unused lines.
> 
>     [03/05] qemu-iotests: Add VM method qtest() to iotests.py
>             Remove duplicated VM.qtest definition.
> 
>     [05/05] qemu-iotests: Add 080 for IO throttling
>             Check for lower bound (0.9 * limit * seconds).
>             Remove unused lines.
>             Fix checking of total bps and iops by adding up read and write.
> 
> 
> 
> Fam Zheng (5):
>   qemu-io: Account IO by aio_read and aio_write
>   qtest: Add scripts/qtest/qtest.py
>   qemu-iotests: Add VM method qtest() to iotests.py
>   qemu-iotests: Allow caller to disable underscore convertion for qmp
>   qemu-iotests: Add 080 for IO throttling
> 
>  qemu-io-cmds.c                |  10 +++
>  scripts/qtest                 |   5 --
>  scripts/qtest/qtest.py        |  74 ++++++++++++++++++
>  tests/qemu-iotests/080        | 175 ++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/080.out    |   5 ++
>  tests/qemu-iotests/group      |   1 +
>  tests/qemu-iotests/iotests.py |  24 +++++-
>  7 files changed, 285 insertions(+), 9 deletions(-)
>  delete mode 100755 scripts/qtest
>  create mode 100644 scripts/qtest/qtest.py
>  create mode 100755 tests/qemu-iotests/080
>  create mode 100644 tests/qemu-iotests/080.out

Is this series still alive?

Just going through old patch series.

Stefan

      parent reply	other threads:[~2014-06-02 13:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11  6:40 [Qemu-devel] [PATCH v3 0/5] qemu-iotests: Test case for IO throttling Fam Zheng
2014-02-11  6:40 ` [Qemu-devel] [PATCH v3 1/5] qemu-io: Account IO by aio_read and aio_write Fam Zheng
2014-02-11  6:40 ` [Qemu-devel] [PATCH v3 2/5] qtest: Add scripts/qtest/qtest.py Fam Zheng
2014-02-11 10:41   ` Benoît Canet
2014-02-11  6:41 ` [Qemu-devel] [PATCH v3 3/5] qemu-iotests: Add VM method qtest() to iotests.py Fam Zheng
2014-02-11 10:58   ` Benoît Canet
2014-02-11  6:41 ` [Qemu-devel] [PATCH v3 4/5] qemu-iotests: Allow caller to disable underscore convertion for qmp Fam Zheng
2014-02-11  6:41 ` [Qemu-devel] [PATCH v3 5/5] qemu-iotests: Add 080 for IO throttling Fam Zheng
2014-02-11 10:41   ` Benoît Canet
2014-06-02 13:41 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140602134148.GH3049@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=benoit.canet@irqsave.net \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).