From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrSUw-00060x-Gq for qemu-devel@nongnu.org; Mon, 02 Jun 2014 09:42:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrSUq-0005NJ-Mm for qemu-devel@nongnu.org; Mon, 02 Jun 2014 09:41:58 -0400 Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:47517) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrSUq-0005N7-Gl for qemu-devel@nongnu.org; Mon, 02 Jun 2014 09:41:52 -0400 Received: by mail-wg0-f52.google.com with SMTP id l18so5074956wgh.23 for ; Mon, 02 Jun 2014 06:41:51 -0700 (PDT) Date: Mon, 2 Jun 2014 15:41:48 +0200 From: Stefan Hajnoczi Message-ID: <20140602134148.GH3049@stefanha-thinkpad.redhat.com> References: <1392100862-25943-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1392100862-25943-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 0/5] qemu-iotests: Test case for IO throttling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , =?iso-8859-1?Q?Beno=EEt?= Canet , qemu-devel@nongnu.org, Stefan Hajnoczi , pbonzini@redhat.com On Tue, Feb 11, 2014 at 02:40:57PM +0800, Fam Zheng wrote: > This series adds iotest case for IO throttling. > > There is a change in qemu-io sub-commands "aio_read" and "aio_write", which > makes the aio requests accounted and the statistics reflected in blockstats. > > Note that IO throttling implementation allows overcommiting of requests, so the > actual IO happened in a time unit may be a bit larger than given limits. In the > test case, the stats numbers are compared against 110%, to make room for such > flexibility in order to improve determinism. > > v3: Address comments from Benoît. (Thanks for the review!) > > [02/05] qtest: Add scripts/qtest/qtest.py > Fix comments. > Fix socket close order. > Removed unused lines. > > [03/05] qemu-iotests: Add VM method qtest() to iotests.py > Remove duplicated VM.qtest definition. > > [05/05] qemu-iotests: Add 080 for IO throttling > Check for lower bound (0.9 * limit * seconds). > Remove unused lines. > Fix checking of total bps and iops by adding up read and write. > > > > Fam Zheng (5): > qemu-io: Account IO by aio_read and aio_write > qtest: Add scripts/qtest/qtest.py > qemu-iotests: Add VM method qtest() to iotests.py > qemu-iotests: Allow caller to disable underscore convertion for qmp > qemu-iotests: Add 080 for IO throttling > > qemu-io-cmds.c | 10 +++ > scripts/qtest | 5 -- > scripts/qtest/qtest.py | 74 ++++++++++++++++++ > tests/qemu-iotests/080 | 175 ++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/080.out | 5 ++ > tests/qemu-iotests/group | 1 + > tests/qemu-iotests/iotests.py | 24 +++++- > 7 files changed, 285 insertions(+), 9 deletions(-) > delete mode 100755 scripts/qtest > create mode 100644 scripts/qtest/qtest.py > create mode 100755 tests/qemu-iotests/080 > create mode 100644 tests/qemu-iotests/080.out Is this series still alive? Just going through old patch series. Stefan