From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47615)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WrTpU-0007EA-Da
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:07:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WrTpO-0003gM-Fj
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:07:16 -0400
Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:38640 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WrTpO-0003gC-5r
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:07:10 -0400
Date: Mon, 2 Jun 2014 17:07:09 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140602150709.GH8181@irqsave.net>
References: <1401473631-10724-1-git-send-email-armbru@redhat.com>
	<1401473631-10724-9-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1401473631-10724-9-git-send-email-armbru@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 08/10] block: Drop superfluous aligning
 of bdrv_getlength()'s value
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com

The Friday 30 May 2014 =E0 20:13:49 (+0200), Markus Armbruster wrote :
> It returns a multiple of the sector size.
>=20
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> ---
>  block.c       | 1 -
>  block/qcow2.c | 1 -
>  2 files changed, 2 deletions(-)
>=20
> diff --git a/block.c b/block.c
> index 8ebfb79..41837b4 100644
> --- a/block.c
> +++ b/block.c
> @@ -1260,7 +1260,6 @@ void bdrv_append_temp_snapshot(BlockDriverState *=
bs, int flags, Error **errp)
>          error_setg_errno(errp, -total_size, "Could not get image size"=
);
>          goto out;
>      }
> -    total_size &=3D BDRV_SECTOR_MASK;
> =20
>      /* Create the temporary image */
>      ret =3D get_tmp_filename(tmp_filename, PATH_MAX + 1);
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 98f624c..4af09bd 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -1927,7 +1927,6 @@ static int qcow2_write_compressed(BlockDriverStat=
e *bs, int64_t sector_num,
>          /* align end of file to a sector boundary to ease reading with
>             sector based I/Os */
>          cluster_offset =3D bdrv_getlength(bs->file);
> -        cluster_offset =3D (cluster_offset + 511) & ~511;
>          bdrv_truncate(bs->file, cluster_offset);
>          return 0;
>      }
> --=20
> 1.9.3
>=20
>=20

Reviewed-by: Benoit Canet <benoit@irqsave.net>