From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53594)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WrUDC-0006jv-1v
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:31:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WrUD4-00045I-Hz
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:31:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37274)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WrUD4-000440-8B
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:31:38 -0400
Date: Mon, 2 Jun 2014 17:31:26 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140602153126.GF4045@noname.str.redhat.com>
References: <1401718539-11304-1-git-send-email-cnanakos@grnet.gr>
	<1401718539-11304-2-git-send-email-cnanakos@grnet.gr>
	<538C8A7D.1020402@redhat.com> <538C929B.6000304@grnet.gr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <538C929B.6000304@grnet.gr>
Subject: Re: [Qemu-devel] [PATCH v2 1/1] block: Support Archipelago as a
 QEMU block backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chrysostomos Nanakos <cnanakos@grnet.gr>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

Am 02.06.2014 um 17:04 hat Chrysostomos Nanakos geschrieben:
> Hi,
> 
> On 06/02/2014 05:30 PM, Eric Blake wrote:
> >On 06/02/2014 08:15 AM, Chrysostomos Nanakos wrote:
> >>VM Image on Archipelago volume is specified like this:
> >>
> >>file=archipelago:<volumename>[/mport=<mapperd_port>[:vport=<vlmcd_port>]]
> >>or
> >I still think that there is no need to burden the code with this
> >shorthand...
> 
> If everyone agrees I can totally remove that part.

I don't think it's a bad idea to provide a shortcut for human users. The
important point is just that internally it's not the main interface, but
mapped to the structured option (which I think your patch achieves now).

> >>file.driver=archipelago,file.volume=<volumename>[,file.mport=<mapperd_port>[,
> >>file.vport=<vlmcd_port>]]
> >...when this version is easier to support.  Older protocols have file=
> >abuse due to back-compat reasons, but new protocols should not start out
> >with baggage.
> >
> >
> >>---
> >>  MAINTAINERS         |    5 +
> >>  block/Makefile.objs |    1 +
> >>  block/archipelago.c | 1174 +++++++++++++++++++++++++++++++++++++++++++++++++++
> >This is a lot to review at once - is there any reasonable way to break
> >it into a series of smaller patches?
> 
> It will be really difficult to break it in smaller patches, and I
> believe it will more difficult for someone to review it.

Not sure how much easier the review would become, but the obvious split
that works almost always is to do a read-only driver in patch 1, and
then add write and create support in patches 2 and 3.

Kevin