From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrUO0-0004U2-3b for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:43:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrUNs-0008B4-3D for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:42:56 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:53370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrUNr-0008AH-Py for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:42:48 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 2 Jun 2014 16:42:45 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 14F4E2190041 for ; Mon, 2 Jun 2014 16:42:32 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s52Fggph5898458 for ; Mon, 2 Jun 2014 15:42:42 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s52Fgfar020761 for ; Mon, 2 Jun 2014 09:42:41 -0600 Date: Mon, 2 Jun 2014 17:42:39 +0200 From: Cornelia Huck Message-ID: <20140602174239.7b79c3e5.cornelia.huck@de.ibm.com> In-Reply-To: <1401448669-4655-4-git-send-email-stefanha@redhat.com> References: <1401448669-4655-1-git-send-email-stefanha@redhat.com> <1401448669-4655-4-git-send-email-stefanha@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 3/8] virtio-blk: move x-data-plane qdev property to virtio-blk.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: pbonzini@redhat.com, peter.crosthwaite@xilinx.com, fred.konrad@greensocs.com, qemu-devel@nongnu.org, afaerber@suse.de On Fri, 30 May 2014 13:17:44 +0200 Stefan Hajnoczi wrote: > Move the x-data-plane property. Originally it was outside since not > every transport may wish to support dataplane. But that makes little > sense when we have a dedicated CONFIG_VIRTIO_BLK_DATA_PLANE ifdef > already. This would add a x-data-plane property to s390-virtio devices, which leads to insta-death if enabled since s390-virtio devices don't have guest notifiers, no? Just an observation; in general, moving the property makes sense to me. > > This move makes it easier to switch to property aliases in the next > patch. > > Signed-off-by: Stefan Hajnoczi > Reviewed-by: Peter Crosthwaite > --- > hw/s390x/virtio-ccw.c | 3 --- > hw/virtio/virtio-pci.c | 3 --- > include/hw/virtio/virtio-blk.h | 8 ++++++++ > 3 files changed, 8 insertions(+), 6 deletions(-) >