From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc: pbonzini@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 0/3, ping] SMBIOS cleanup round
Date: Mon, 2 Jun 2014 23:02:20 +0300 [thread overview]
Message-ID: <20140602200220.GB5148@redhat.com> (raw)
In-Reply-To: <20140602171318.GB1653@ERROL.INI.CMU.EDU>
On Mon, Jun 02, 2014 at 01:13:18PM -0400, Gabriel L. Somlo wrote:
> Hi,
>
> On Mon, May 19, 2014 at 10:44:48PM +0300, Michael S. Tsirkin wrote:
> > On Mon, May 19, 2014 at 10:09:52AM -0400, Gabriel L. Somlo wrote:
> > > Changelog:
> > >
> > > new in v4:
> > > - slightly improved commit blurbs
> > >
> > > v3:
> > > - endian-ness fix (1/3) now correctly handles cpuid version and features
> > > - included documentation (qemu-options.hx) for type 0 uefi flag (2/3)
> > > - fixed type 17 field sizes ("word" means 16 bits, not 32 :) :)
> > >
> > >
> > > v2:
> > > - fix endian-ness for *all* larger-than-8bit fields (patch 1/2)
> > > - resubmit type0 update (2/2) with appropriate endian-ness fix
> > > for 64-bit field.
> > >
> >
> > Thanks!
>
> http://patchwork.ozlabs.org/patch/350248/
> http://patchwork.ozlabs.org/patch/350253/
> http://patchwork.ozlabs.org/patch/350252/
>
> Not sure where we left this, was somebody going to pull these, or are
> we waiting for the unit tests:
>
> > One question: we don't seem to have unit-test for this
> > interface in qemu, do we?
> > I would like to see at least a basic test along the lines of
> > tests/acpi-test.c: run bios to load tables from QEMU,
> > then do some basic checks on the tables that bios loaded.
>
> ... in which case:
>
> http://patchwork.ozlabs.org/patch/353072/
> http://patchwork.ozlabs.org/patch/353073/
>
> Wondering if I should send out another series containing all five, or
> if the first three are already "accepted", in which case "ping" only
> on the latter two :)
>
> Thanks much,
> --Gabriel
These are all in my tree.
I plan to send pull request Thursday.
--
MST
next prev parent reply other threads:[~2014-06-02 20:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 14:09 [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round Gabriel L. Somlo
2014-05-19 14:09 ` [Qemu-devel] [PATCH v4 1/3] SMBIOS: Fix endian-ness when populating multi-byte fields Gabriel L. Somlo
2014-05-19 14:09 ` [Qemu-devel] [PATCH v4 2/3] SMBIOS: Update Type 0 struct generator for machines >= 2.1 Gabriel L. Somlo
2014-05-19 14:09 ` [Qemu-devel] [PATCH v4 3/3] SMBIOS: Fix type 17 field sizes Gabriel L. Somlo
2014-05-19 16:09 ` [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round Michael S. Tsirkin
2014-05-20 6:57 ` Gerd Hoffmann
2014-05-19 19:44 ` Michael S. Tsirkin
2014-05-20 19:01 ` Gabriel L. Somlo
2014-05-23 1:27 ` Gabriel L. Somlo
2014-05-23 9:00 ` Michael S. Tsirkin
2014-05-23 21:01 ` Gabriel L. Somlo
2014-05-26 6:30 ` Markus Armbruster
2014-06-02 17:13 ` [Qemu-devel] [PATCH v4 0/3, ping] " Gabriel L. Somlo
2014-06-02 20:02 ` Michael S. Tsirkin [this message]
2014-06-04 19:47 ` Michael S. Tsirkin
2014-06-04 20:02 ` Gabriel L. Somlo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602200220.GB5148@redhat.com \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=gsomlo@gmail.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).