From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33841)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1WrYj9-0004bK-Qo
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 16:21:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1WrYj1-000104-5Q
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 16:21:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57165)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1WrYj0-0000zt-Se
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 16:20:55 -0400
Date: Mon, 2 Jun 2014 17:20:38 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20140602202038.GA12036@amt.cnet>
References: <20140530201145.194061806@amt.cnet>
	<20140602175104.579823673@amt.cnet>
	<20140602175345.235004414@amt.cnet> <538CD111.30604@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <538CD111.30604@redhat.com>
Subject: Re: [Qemu-devel] [patch 1/3] mc146818rtc: add rtc_reset_reinjection
	QMP command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: gleb@kernel.org, pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, mprivozn@redhat.com

On Mon, Jun 02, 2014 at 01:31:29PM -0600, Eric Blake wrote:
> On 06/02/2014 11:51 AM, mtosatti@redhat.com wrote:
> > It is necessary to reset RTC interrupt reinjection backlog if
> > guest time is synchronized via a different mechanism, such as 
> > QGA's guest-set-time command.
> > 
> > Failing to do so causes both corrections to be applied (summed),
> > resulting in an incorrect guest time.
> > 
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> > 
> > Index: qemu/hw/timer/mc146818rtc.c
> 
> Still no --- separator between your commit message and the patch body.
> Are you using 'git send-email'?

OK, diffstats on every patch.

> > Index: qemu/qapi-schema.json
> > ===================================================================
> > --- qemu.orig/qapi-schema.json
> > +++ qemu/qapi-schema.json
> > @@ -4722,3 +4722,15 @@
> >                'btn'     : 'InputBtnEvent',
> >                'rel'     : 'InputMoveEvent',
> >                'abs'     : 'InputMoveEvent' } }
> > +
> > +##
> > +# @: rtc-reset-reinjection
> 
> s/: // to resemble most other commands

Several commands have ":". What is the correct syntax and why?

> > +# This command will reset RTC's interrupt reinjection backlog.
> 
> s/RTC's/the RTC/
> 
> > +# Can be used if another mechanism to synchronize guest time
> > +# is in effect, for example QEMU guest agents guest-set-time
> 
> s/agents/agent's/

Fixed.

> > +# command.
> > +#
> > +# Since: 2.1
> > +##
> > +{ 'command': 'rtc-reset-reinjection' }
> > Index: qemu/qmp-commands.hx
> > ===================================================================
> > --- qemu.orig/qmp-commands.hx
> > +++ qemu/qmp-commands.hx
> > @@ -3572,3 +3572,26 @@ Example:
> >                     } } ] }
> >  
> >  EQMP
> > +
> > +#if defined (TARGET_I386)
> > +    {
> > +        .name       = "rtc_reset_reinjection",
> 
> s/rtc_reset_reinjection/rtc-reset-reinjection/

This is a function name.