From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wrwj4-0008IQ-9g for qemu-devel@nongnu.org; Tue, 03 Jun 2014 17:58:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wrwiy-0007OK-7P for qemu-devel@nongnu.org; Tue, 03 Jun 2014 17:58:34 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:52858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wrwix-0007O3-Rs for qemu-devel@nongnu.org; Tue, 03 Jun 2014 17:58:28 -0400 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Jun 2014 15:58:24 -0600 Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 04F451FF0040 for ; Tue, 3 Jun 2014 15:58:22 -0600 (MDT) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by b03cxnp07029.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s53JsxpG9896446 for ; Tue, 3 Jun 2014 21:54:59 +0200 Received: from d03av02.boulder.ibm.com (localhost [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s53LwLL5032692 for ; Tue, 3 Jun 2014 15:58:22 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <538E405B.2020204@redhat.com> References: <20140522135641.6110.28511.stgit@hds.com> <20140522135653.6110.79891.stgit@hds.com> <20140603212147.3985.99693@loki> <538E405B.2020204@redhat.com> Message-ID: <20140603215820.3985.70471@loki> Date: Tue, 03 Jun 2014 16:58:20 -0500 Subject: Re: [Qemu-devel] [PATCH v3 1/2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Tomoki Sekiyama , qemu-devel@nongnu.org Cc: mitsuhiro.tanino@hds.com Quoting Eric Blake (2014-06-03 16:38:35) > On 06/03/2014 03:21 PM, Michael Roth wrote: > > Quoting Tomoki Sekiyama (2014-05-22 08:56:53) > >> When an array of mount point paths is specified as 'mountpoints' argum= ent > >> of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the= file > >> systems mounted on specified paths in Linux. > >> This would be useful when the host wants to create partial disk snapsh= ots. > > = > > Since this isn't really applicable for win32, and it's hard to discover > > optional params via guest-info without some extensive changes to how we= handle > > capabilities negotiation, I think it makes more sense to introduce a new > > command for this, something like guest-fsfreeze-freeze-filesystems, whi= ch we > > can easily discover and properly mark as unsupported on win32. > = > Bikeshedding on the proposed name: given that 'fs' is an abbreviation of > 'filesystem', "fsfreeze-freeze-filesystems" sounds rather redundant. I > would suggest guest-fsfreeze-list as a shorter name that conveys the > intent, without quite as much repetition. Somewhat agree, though I think we should retain the guest--<= verb> structure and at least go with guest-fsfreeze-freeze-list. I do think that is easy to confuse with 'get me a list of frozen mounts', b= ut probably nothing a little documentation shouldn't clarify. I'll throw guest-fsfreeze-freeze-mountpoints out there, but don't have a strong prefer= ence either way. > = > > = > > Other than that looks good. > > = > = > -- = > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org