qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] target-microblaze: Delete unused sign_extend() function
Date: Wed, 4 Jun 2014 09:13:35 +0200	[thread overview]
Message-ID: <20140604071335.GH3378@toto> (raw)
In-Reply-To: <1401818361-1581-1-git-send-email-peter.maydell@linaro.org>

On Tue, Jun 03, 2014 at 06:59:21PM +0100, Peter Maydell wrote:
> The sign_extend() function is unused; delete it.

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Peter, feel free to push this straight in.

Thanks,
Edgar

> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> We have sextract() for this these days anyway.
> ---
>  target-microblaze/translate.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c
> index 488df2d..50c214b 100644
> --- a/target-microblaze/translate.c
> +++ b/target-microblaze/translate.c
> @@ -98,19 +98,6 @@ static const char *special_regnames[] =
>      "sr16", "sr17", "sr18"
>  };
>  
> -/* Sign extend at translation time.  */
> -static inline int sign_extend(unsigned int val, unsigned int width)
> -{
> -        int sval;
> -
> -        /* LSL.  */
> -        val <<= 31 - width;
> -        sval = val;
> -        /* ASR.  */
> -        sval >>= 31 - width;
> -        return sval;
> -}
> -
>  static inline void t_sync_flags(DisasContext *dc)
>  {
>      /* Synch the tb dependent flags between translator and runtime.  */
> -- 
> 1.9.2
> 

  reply	other threads:[~2014-06-04  7:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 17:59 [Qemu-devel] [PATCH] target-microblaze: Delete unused sign_extend() function Peter Maydell
2014-06-04  7:13 ` Edgar E. Iglesias [this message]
2014-06-08 11:03 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140604071335.GH3378@toto \
    --to=edgar.iglesias@gmail.com \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).