From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49088)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Ws5Vd-0001if-Rb
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 03:21:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Ws5VZ-0001HW-4A
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 03:21:17 -0400
Date: Wed, 4 Jun 2014 09:13:35 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20140604071335.GH3378@toto>
References: <1401818361-1581-1-git-send-email-peter.maydell@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1401818361-1581-1-git-send-email-peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] target-microblaze: Delete unused
	sign_extend() function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org

On Tue, Jun 03, 2014 at 06:59:21PM +0100, Peter Maydell wrote:
> The sign_extend() function is unused; delete it.

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Peter, feel free to push this straight in.

Thanks,
Edgar

> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> We have sextract() for this these days anyway.
> ---
>  target-microblaze/translate.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c
> index 488df2d..50c214b 100644
> --- a/target-microblaze/translate.c
> +++ b/target-microblaze/translate.c
> @@ -98,19 +98,6 @@ static const char *special_regnames[] =
>      "sr16", "sr17", "sr18"
>  };
>  
> -/* Sign extend at translation time.  */
> -static inline int sign_extend(unsigned int val, unsigned int width)
> -{
> -        int sval;
> -
> -        /* LSL.  */
> -        val <<= 31 - width;
> -        sval = val;
> -        /* ASR.  */
> -        sval >>= 31 - width;
> -        return sval;
> -}
> -
>  static inline void t_sync_flags(DisasContext *dc)
>  {
>      /* Synch the tb dependent flags between translator and runtime.  */
> -- 
> 1.9.2
>