From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws68x-0004X7-1d for qemu-devel@nongnu.org; Wed, 04 Jun 2014 04:02:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ws68s-0008PG-67 for qemu-devel@nongnu.org; Wed, 04 Jun 2014 04:01:54 -0400 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:41424) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws68r-0008Om-Vx for qemu-devel@nongnu.org; Wed, 04 Jun 2014 04:01:50 -0400 Received: by mail-wg0-f50.google.com with SMTP id x12so8090618wgg.9 for ; Wed, 04 Jun 2014 01:01:49 -0700 (PDT) Date: Wed, 4 Jun 2014 10:01:46 +0200 From: Stefan Hajnoczi Message-ID: <20140604080146.GB21259@stefanha-thinkpad.redhat.com> References: <1401572382-11667-1-git-send-email-kroosec@gmail.com> <1401572382-11667-2-git-send-email-kroosec@gmail.com> <20140602123206.GF3049@stefanha-thinkpad.redhat.com> <20140602220902.GB5283@Inspiron-3521> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140602220902.GB5283@Inspiron-3521> Subject: Re: [Qemu-devel] [PATCH 1/3] nbd: Handle fixed new-style clients. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hani Benhabiles Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On Mon, Jun 02, 2014 at 11:09:02PM +0100, Hani Benhabiles wrote: > On Mon, Jun 02, 2014 at 02:32:06PM +0200, Stefan Hajnoczi wrote: > > On Sat, May 31, 2014 at 10:39:40PM +0100, Hani Benhabiles wrote: > > > Signed-off-by: Hani Benhabiles > > > --- > > > include/block/nbd.h | 6 ++++++ > > > nbd.c | 12 +++++++----- > > > 2 files changed, 13 insertions(+), 5 deletions(-) > > > > No explanation or link to specification for this new flag field? What's > > different about a new-style client? > > With this flag is set, the server tells the client that it can send another > option if the server got a request with an option it doesn't understand (instead > of the server closing the connection.) Thus, the while(1) loop in 2/3. Great, please include this explanation in the commit description. > The kernel in Documentation/blockdev/nbd.txt points to the NBD project for > documentation. The proto documentation is in [1]. Shouldn't Qemu also do the > same ? > > [1] https://github.com/yoe/nbd/blob/master/doc/proto.txt Please add the link as a comment to the top of nbd.c. Stefan