qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Chunyan Liu <cyliu@suse.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, l@dorileo.org
Subject: Re: [Qemu-devel] [PATCH v27 00/33] replace QEMUOptionParameter with QemuOpts
Date: Wed, 4 Jun 2014 11:18:24 +0200	[thread overview]
Message-ID: <20140604091824.GB26902@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1399456738-11132-1-git-send-email-cyliu@suse.com>

On Wed, May 07, 2014 at 05:58:25PM +0800, Chunyan Liu wrote:
> This patch series is to replace QEMUOptionParameter with QemuOpts, so that only
> one Qemu Option structure is kept in QEMU code.
> 
> ---
> Changes to v26:
>   * Following Eric's comment, backward split 2/33, 3/33.
>     (repurpose qemu_opts_print first, add def_value_str to QemuOptDesc later).
>   * Fix memory free in qemu_opts_append to solve iotest issue. 10/33
>   * Following Eric's comment, remove the end '.' in error message. And update
>     qemu-iotests .out file. 12/33
>   * Following Eric's comment, fix memory free in vvfat.c 13/33
>   * Following Eric's comment, split qcow2 patch into two. 19/33, 20/33:
>     export qemu_opt_find first, add qcow2 driver patch later.
>   * rebase to git master
> 
> All patches are also available from:
> https://github.com/chunyanliu/qemu/commits/QemuOpts

Please git rebase -x 'make && make check && make check-block' -i master:

qemu-img.c: In function ‘print_block_option_help’:
qemu-img.c:289:36: error: ‘create_options’ undeclared (first use in this
function)
             free_option_parameters(create_options);
	                                         ^

  parent reply	other threads:[~2014-06-04  9:18 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07  9:58 [Qemu-devel] [PATCH v27 00/33] replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 01/33] QemuOpts: move find_desc_by_name ahead for later calling Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 02/33] QemuOpts: repurpose qemu_opts_print to replace print_option_parameters Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 03/33] QemuOpts: add def_value_str to QemuOptDesc Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 04/33] qapi: output def_value_str when query command line options Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 05/33] QemuOpts: change opt->name|str from (const char *) to (char *) Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 06/33] QemuOpts: move qemu_opt_del ahead for later calling Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 07/33] QemuOpts: add qemu_opt_get_*_del functions for replace work Chunyan Liu
2014-06-04  8:54   ` Stefan Hajnoczi
2014-06-05  3:32     ` Chun Yan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 08/33] QemuOpts: add qemu_opts_print_help to replace print_option_help Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 09/33] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 10/33] QemuOpts: add qemu_opts_append to replace append_option_parameters Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 11/33] QemuOpts: check NULL input for qemu_opts_del Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 12/33] change block layer to support both QemuOpts and QEMUOptionParamter Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 13/33] vvfat.c: handle cross_driver's create_options and create_opts Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 14/33] cow.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 15/33] gluster.c: " Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 16/33] iscsi.c: " Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 17/33] nfs.c: " Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 18/33] qcow.c: " Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 19/33] QemuOpts: export qemu_opt_find Chunyan Liu
2014-06-05 22:12   ` Eric Blake
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 20/33] qcow2.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-06-05 22:27   ` Eric Blake
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 21/33] qed.c: " Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 22/33] raw-posix.c: " Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 23/33] raw-win32.c: " Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 24/33] raw_bsd.c: " Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 25/33] rbd.c: " Chunyan Liu
2014-06-04  9:18 ` Stefan Hajnoczi [this message]
2014-06-05  2:34   ` [Qemu-devel] [PATCH v27 00/33] " Chun Yan Liu
  -- strict thread matches above, loose matches on Subject: below --
2014-05-07  9:54 Chunyan Liu
2014-05-07 10:17 ` Chun Yan Liu
2014-05-14  8:58 ` Chun Yan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140604091824.GB26902@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=cyliu@suse.com \
    --cc=l@dorileo.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).