From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws7L7-0002pk-JV for qemu-devel@nongnu.org; Wed, 04 Jun 2014 05:18:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ws7L2-0008Lp-6Q for qemu-devel@nongnu.org; Wed, 04 Jun 2014 05:18:33 -0400 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:55153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws7L1-0008LS-Vn for qemu-devel@nongnu.org; Wed, 04 Jun 2014 05:18:28 -0400 Received: by mail-wg0-f42.google.com with SMTP id y10so7956031wgg.13 for ; Wed, 04 Jun 2014 02:18:27 -0700 (PDT) Date: Wed, 4 Jun 2014 11:18:24 +0200 From: Stefan Hajnoczi Message-ID: <20140604091824.GB26902@stefanha-thinkpad.redhat.com> References: <1399456738-11132-1-git-send-email-cyliu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1399456738-11132-1-git-send-email-cyliu@suse.com> Subject: Re: [Qemu-devel] [PATCH v27 00/33] replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu Cc: qemu-devel@nongnu.org, stefanha@redhat.com, l@dorileo.org On Wed, May 07, 2014 at 05:58:25PM +0800, Chunyan Liu wrote: > This patch series is to replace QEMUOptionParameter with QemuOpts, so that only > one Qemu Option structure is kept in QEMU code. > > --- > Changes to v26: > * Following Eric's comment, backward split 2/33, 3/33. > (repurpose qemu_opts_print first, add def_value_str to QemuOptDesc later). > * Fix memory free in qemu_opts_append to solve iotest issue. 10/33 > * Following Eric's comment, remove the end '.' in error message. And update > qemu-iotests .out file. 12/33 > * Following Eric's comment, fix memory free in vvfat.c 13/33 > * Following Eric's comment, split qcow2 patch into two. 19/33, 20/33: > export qemu_opt_find first, add qcow2 driver patch later. > * rebase to git master > > All patches are also available from: > https://github.com/chunyanliu/qemu/commits/QemuOpts Please git rebase -x 'make && make check && make check-block' -i master: qemu-img.c: In function ‘print_block_option_help’: qemu-img.c:289:36: error: ‘create_options’ undeclared (first use in this function) free_option_parameters(create_options); ^