From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/5] virtio-blk: Drop VirtIOBlockReq.read
Date: Wed, 4 Jun 2014 11:28:41 +0200 [thread overview]
Message-ID: <20140604092841.GD26902@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <538DCF99.9030602@redhat.com>
On Tue, Jun 03, 2014 at 03:37:29PM +0200, Paolo Bonzini wrote:
> > QEMUIOVector *inhdr; /* iovecs for virtio_blk_inhdr */
>
> This can be unified with the "in" field; the status is only one byte, so
> using a full-blown QEMUIOVector is overkill. Stefan, what do you think?
I thought about this when initially writing the code, but it seemed like
a hack to assume virtio_blk_inhdr will always be 1 byte.
virtio-blk is unlikely to change much since the focus is on virtio-scsi
rather than piling on more virtio-blk feature.
I still prefer we treat it like a struct without making size
assumptions, but if the code turns out to be nicer then I don't mind.
Stefan
prev parent reply other threads:[~2014-06-04 9:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 12:52 [Qemu-devel] [PATCH 0/5] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq Fam Zheng
2014-06-03 12:52 ` [Qemu-devel] [PATCH 1/5] virtio-blk: Move VirtIOBlockReq to header Fam Zheng
2014-06-03 12:52 ` [Qemu-devel] [PATCH 2/5] virtio-blk: Convert VirtIOBlockReq.elem to pointer Fam Zheng
2014-06-03 12:52 ` [Qemu-devel] [PATCH 3/5] virtio-blk: Merge VirtIOBlockRequest into VirtIOBlockReq Fam Zheng
2014-06-03 12:52 ` [Qemu-devel] [PATCH 4/5] virtio-blk: Drop bounce buffer from dataplane code Fam Zheng
2014-06-03 13:28 ` Paolo Bonzini
2014-06-03 12:52 ` [Qemu-devel] [PATCH 5/5] virtio-blk: Drop VirtIOBlockReq.read Fam Zheng
2014-06-03 13:37 ` Paolo Bonzini
2014-06-04 7:10 ` Fam Zheng
2014-06-04 7:53 ` Fam Zheng
2014-06-04 8:42 ` Paolo Bonzini
2014-06-04 11:03 ` Fam Zheng
2014-06-04 11:10 ` Paolo Bonzini
2014-06-04 9:28 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604092841.GD26902@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).