From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws7Ww-0003RF-Tu for qemu-devel@nongnu.org; Wed, 04 Jun 2014 05:30:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ws7Wr-0005YJ-Fd for qemu-devel@nongnu.org; Wed, 04 Jun 2014 05:30:46 -0400 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:45903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws7Wq-0005XH-S9 for qemu-devel@nongnu.org; Wed, 04 Jun 2014 05:30:41 -0400 Received: by mail-wg0-f50.google.com with SMTP id x12so8218104wgg.9 for ; Wed, 04 Jun 2014 02:30:40 -0700 (PDT) Date: Wed, 4 Jun 2014 11:30:37 +0200 From: Stefan Hajnoczi Message-ID: <20140604093037.GE26902@stefanha-thinkpad.redhat.com> References: <1401740121-15506-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1401740121-15506-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] qemu-img: Document check exit codes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Markus Armbruster On Mon, Jun 02, 2014 at 10:15:21PM +0200, Max Reitz wrote: > The exit code 63 (check not supported by image format) was not even > documented in the comment above the check command in the source code; > add it, as it does indeed seem useful. > > Also, document all of check's exit codes in the manpage. > > Signed-off-by: Max Reitz > Reported-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > v2: Fixed spelling mistakes [Eric] > --- > qemu-img.c | 9 +++++---- > qemu-img.texi | 23 +++++++++++++++++++++++ > 2 files changed, 28 insertions(+), 4 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan