From: Stefan Hajnoczi <stefanha@gmail.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Lluís Vilanova" <vilanova@ac.upc.edu>
Subject: Re: [Qemu-devel] [PATCH v2] trace: Replace fprintf with error_report and print location
Date: Wed, 4 Jun 2014 13:05:26 +0200 [thread overview]
Message-ID: <20140604110526.GA11073@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1401690850-24854-1-git-send-email-aik@ozlabs.ru>
On Mon, Jun 02, 2014 at 04:34:10PM +1000, Alexey Kardashevskiy wrote:
> This replaces fprintf(stderr) with error_report.
>
> This moves local variables to the beginning of the function to comply
> with QEMU's coding style.
>
> Suggested-by: Lluís Vilanova <vilanova@ac.upc.edu>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> Changes:
> v2:
> * polished commit log
> ---
> trace/control.c | 31 ++++++++++++++++++-------------
> 1 file changed, 18 insertions(+), 13 deletions(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
prev parent reply other threads:[~2014-06-04 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 6:34 [Qemu-devel] [PATCH v2] trace: Replace fprintf with error_report and print location Alexey Kardashevskiy
2014-06-04 11:05 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604110526.GA11073@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).