From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws90h-0004UU-AN for qemu-devel@nongnu.org; Wed, 04 Jun 2014 07:05:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ws90d-0008DR-0y for qemu-devel@nongnu.org; Wed, 04 Jun 2014 07:05:35 -0400 Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]:55723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws90c-0008Cy-7G for qemu-devel@nongnu.org; Wed, 04 Jun 2014 07:05:30 -0400 Received: by mail-wg0-f49.google.com with SMTP id m15so8109370wgh.8 for ; Wed, 04 Jun 2014 04:05:29 -0700 (PDT) Date: Wed, 4 Jun 2014 13:05:26 +0200 From: Stefan Hajnoczi Message-ID: <20140604110526.GA11073@stefanha-thinkpad.redhat.com> References: <1401690850-24854-1-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1401690850-24854-1-git-send-email-aik@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH v2] trace: Replace fprintf with error_report and print location List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , =?iso-8859-1?Q?Llu=EDs?= Vilanova On Mon, Jun 02, 2014 at 04:34:10PM +1000, Alexey Kardashevskiy wrote: > This replaces fprintf(stderr) with error_report. > > This moves local variables to the beginning of the function to comply > with QEMU's coding style. > > Suggested-by: Lluís Vilanova > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v2: > * polished commit log > --- > trace/control.c | 31 ++++++++++++++++++------------- > 1 file changed, 18 insertions(+), 13 deletions(-) Thanks, applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan