qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Maria Kustova <maxa@catit.be>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, Maria Kustova <maria.k@catit.be>
Subject: Re: [Qemu-devel] [RFC] image-fuzzer: Documentation for the image fuzzer
Date: Wed, 4 Jun 2014 15:04:54 +0200	[thread overview]
Message-ID: <20140604130454.GH11073@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1401529703-8227-1-git-send-email-maria.k@catit.be>

On Sat, May 31, 2014 at 01:48:23PM +0400, Maria Kustova wrote:

Looks like a good starting point.  Once the command-line interface is
settled it would be good to document how to use the fuzzer and show
examples.  That can be done in later patches.

> +Module interfaces
> +-----------------

Here it would be worth briefly explaining that the fuzzer can be
extended by implementing additional image generator modules.  This puts
the section into context so the reader know why you are explaining the
module interface.

> +
> +* Test runner/image generator
> +
> +The runner calls an image generator specifying path to a test image file, its
> +size and seed. An image generator is expected to create a test image of the
> +specified size using the specified seed for random generator and write an image
> +to file. File should be created if it doesn't exist or overwritten otherwise.
> +Size and seed arguments are optional.
> +
> +An image generator should return seeds for the logging purpose.

Since the runner passes the random number seed to the image generator,
why does the image generator need to return the seed back to the runner?

           reply	other threads:[~2014-06-04 13:05 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1401529703-8227-1-git-send-email-maria.k@catit.be>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140604130454.GH11073@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=maria.k@catit.be \
    --cc=maxa@catit.be \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).