* Re: [Qemu-devel] [RFC] image-fuzzer: Documentation for the image fuzzer
[not found] <1401529703-8227-1-git-send-email-maria.k@catit.be>
@ 2014-06-04 13:04 ` Stefan Hajnoczi
0 siblings, 0 replies; only message in thread
From: Stefan Hajnoczi @ 2014-06-04 13:04 UTC (permalink / raw)
To: Maria Kustova; +Cc: kwolf, famz, qemu-devel, stefanha, Maria Kustova
On Sat, May 31, 2014 at 01:48:23PM +0400, Maria Kustova wrote:
Looks like a good starting point. Once the command-line interface is
settled it would be good to document how to use the fuzzer and show
examples. That can be done in later patches.
> +Module interfaces
> +-----------------
Here it would be worth briefly explaining that the fuzzer can be
extended by implementing additional image generator modules. This puts
the section into context so the reader know why you are explaining the
module interface.
> +
> +* Test runner/image generator
> +
> +The runner calls an image generator specifying path to a test image file, its
> +size and seed. An image generator is expected to create a test image of the
> +specified size using the specified seed for random generator and write an image
> +to file. File should be created if it doesn't exist or overwritten otherwise.
> +Size and seed arguments are optional.
> +
> +An image generator should return seeds for the logging purpose.
Since the runner passes the random number seed to the image generator,
why does the image generator need to return the seed back to the runner?
^ permalink raw reply [flat|nested] only message in thread