From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51569)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WsCxY-0001ly-Iz
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 11:18:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WsCxQ-0007yy-RU
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 11:18:36 -0400
Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:45452 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WsCxQ-0007xx-Ky
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 11:18:28 -0400
Date: Wed, 4 Jun 2014 17:18:25 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140604151824.GA31602@irqsave.net>
References: <1401537111-10221-1-git-send-email-benoit.canet@irqsave.net>
	<20140604143414.GJ11073@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20140604143414.GJ11073@stefanha-thinkpad.redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v1 00/72] Extract qapi commons and block
 definitions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>, kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com

The Wednesday 04 Jun 2014 =E0 16:34:14 (+0200), Stefan Hajnoczi wrote :
> On Sat, May 31, 2014 at 01:50:39PM +0200, Beno=EEt Canet wrote:
> > This hudge chainsawing series sit on top of my quorum maintenance ser=
ies.
> >=20
> > It extract commons definition and block definition into separate file=
s.
> >=20
> > -qapi/common.json contains some definition required by all qapi modul=
es
> > -qapi/block-core.json contains core qapi block definition usable with=
out the emulation
> > code.
> > -qapi/block.json is a superset of the previous usable with emulation
> >=20
> > Transaction where left appart because they relies on internal snapsho=
t and hence
> > cannot be included in block-core.json for now.
>=20
> I'm fine with this, it's mostly a mechanical change.
>=20
> But please squash it down into just a few patches:
>=20
> 1. Extract block-core.json and include it.
> 2. Extract block.json and include it.

ok,

>=20
> I also suggest you drop the quorum maintenance command dependency
> because rebasing this series will be no fun.  This way you minimize
> churn.  We can merge this qapi series very quickly, while the quorum
> maintenance series may require more discussion.

I don't mind rebasing this QAPI series 10 times as I don't need I before =
2.2.
Right now the only thing that interest me is getting the quorum maintaina=
nce
series in.

Best regards

Beno=EEt

>=20
> Stefan
>=20