From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsH9J-0004Eg-To for qemu-devel@nongnu.org; Wed, 04 Jun 2014 15:47:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsH9E-0007Db-V7 for qemu-devel@nongnu.org; Wed, 04 Jun 2014 15:47:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsH9E-0007DQ-LK for qemu-devel@nongnu.org; Wed, 04 Jun 2014 15:46:56 -0400 Date: Wed, 4 Jun 2014 22:47:21 +0300 From: "Michael S. Tsirkin" Message-ID: <20140604194721.GA10676@redhat.com> References: <1400508595-23024-1-git-send-email-somlo@cmu.edu> <20140519194448.GA14502@redhat.com> <20140602171318.GB1653@ERROL.INI.CMU.EDU> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140602171318.GB1653@ERROL.INI.CMU.EDU> Subject: Re: [Qemu-devel] [PATCH v4 0/3, ping] SMBIOS cleanup round List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: pbonzini@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, kraxel@redhat.com On Mon, Jun 02, 2014 at 01:13:18PM -0400, Gabriel L. Somlo wrote: > Hi, > > On Mon, May 19, 2014 at 10:44:48PM +0300, Michael S. Tsirkin wrote: > > On Mon, May 19, 2014 at 10:09:52AM -0400, Gabriel L. Somlo wrote: > > > Changelog: > > > > > > new in v4: > > > - slightly improved commit blurbs > > > > > > v3: > > > - endian-ness fix (1/3) now correctly handles cpuid version and features > > > - included documentation (qemu-options.hx) for type 0 uefi flag (2/3) > > > - fixed type 17 field sizes ("word" means 16 bits, not 32 :) :) > > > > > > > > > v2: > > > - fix endian-ness for *all* larger-than-8bit fields (patch 1/2) > > > - resubmit type0 update (2/2) with appropriate endian-ness fix > > > for 64-bit field. > > > > > > > Thanks! > > http://patchwork.ozlabs.org/patch/350248/ > http://patchwork.ozlabs.org/patch/350253/ > http://patchwork.ozlabs.org/patch/350252/ > > Not sure where we left this, was somebody going to pull these, or are > we waiting for the unit tests: > > > One question: we don't seem to have unit-test for this > > interface in qemu, do we? > > I would like to see at least a basic test along the lines of > > tests/acpi-test.c: run bios to load tables from QEMU, > > then do some basic checks on the tables that bios loaded. > > ... in which case: > > http://patchwork.ozlabs.org/patch/353072/ > http://patchwork.ozlabs.org/patch/353073/ > > Wondering if I should send out another series containing all five, or > if the first three are already "accepted", in which case "ping" only > on the latter two :) > > Thanks much, > --Gabriel Also pls confirm everything necessary is there in my tree: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream