From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
jcody@redhat.com, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: Test BLOCK_JOB_READY event for 0Kb image active commit
Date: Thu, 5 Jun 2014 13:22:15 +0200 [thread overview]
Message-ID: <20140605112215.GJ27366@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1401939756-11150-3-git-send-email-famz@redhat.com>
On Thu, Jun 05, 2014 at 11:42:35AM +0800, Fam Zheng wrote:
> @@ -48,8 +49,11 @@ class ImageCommitTestCase(iotests.QMPTestCase):
> self.assert_qmp(event, 'data/device', 'drive0')
> self.assert_qmp(event, 'data/offset', self.image_len)
> self.assert_qmp(event, 'data/len', self.image_len)
> + if need_ready:
> + assert ready, "Expceting BLOCK_JOB_COMPLETED event"
s/Expceting/Expecting/
Please use TestCase.assert*() methods instead of the assert keyword:
self.assertTrue(ready, msg='Expecting BLOCK_JOB_COMPLETED event')
The assert keyword raises the built-in AssertionError, which may not be
supported by the unittest module:
https://docs.python.org/2/library/unittest.html
next prev parent reply other threads:[~2014-06-05 11:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 3:42 [Qemu-devel] [PATCH 0/3] mirror: Fix behavior for zero byte image Fam Zheng
2014-06-05 3:42 ` [Qemu-devel] [PATCH 1/3] mirror: Go through ready -> complete process for 0 len image Fam Zheng
2014-06-05 11:17 ` Stefan Hajnoczi
2014-06-05 11:26 ` Paolo Bonzini
2014-06-05 3:42 ` [Qemu-devel] [PATCH 2/3] qemu-iotests: Test BLOCK_JOB_READY event for 0Kb image active commit Fam Zheng
2014-06-05 11:22 ` Stefan Hajnoczi [this message]
2014-06-05 3:42 ` [Qemu-devel] [PATCH 3/3] qemu-iotests: Test 0-length image for mirror Fam Zheng
2014-06-05 11:26 ` Stefan Hajnoczi
2014-06-05 3:57 ` [Qemu-devel] [PATCH 0/3] mirror: Fix behavior for zero byte image Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605112215.GJ27366@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).