From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47772)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1WsXSK-0005mN-0k
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:11:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1WsXSE-0000vM-DP
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:11:43 -0400
Received: from afflict.kos.to ([92.243.29.197]:37600)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1WsXSE-0000ud-6N
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:11:38 -0400
Date: Thu, 5 Jun 2014 16:11:34 +0300
From: Riku Voipio <riku.voipio@iki.fi>
Message-ID: <20140605131134.GA16772@afflict.kos.to>
References: <1399721153-22248-1-git-send-email-peter.maydell@linaro.org>
	<CAFEAcA-mSVEhGJmatMY9CpQFNjQO+jW1yCDKMiGiTkTHtVq7ZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA-mSVEhGJmatMY9CpQFNjQO+jW1yCDKMiGiTkTHtVq7ZA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] linux-user/uname: Return correct uname
 string for x86_64
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Riku Voipio <riku.voipio@iki.fi>, QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

Hi,

On Tue, Jun 03, 2014 at 03:07:59PM +0100, Peter Maydell wrote:
> Ping!

Looks good, I'll collect this and other linux-user patches and submit linux-user update
by tomorrow.

Riku

> thanks
> -- PMM
> 
> On 10 May 2014 12:25, Peter Maydell <peter.maydell@linaro.org> wrote:
> > We were returning the incorrect uname string (with a hyphen, not
> > an underscore) for x86_64. Fix this by removing the x86_64 special
> > case, since the default "just use UNAME_MACHINE" behaviour suffices.
> > This leaves cpu_to_uname_machine() special cases for only those
> > architectures which need to vary the string based on runtime CPU
> > features.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> >  linux-user/uname.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/linux-user/uname.c b/linux-user/uname.c
> > index f5d4c66..1e6560d 100644
> > --- a/linux-user/uname.c
> > +++ b/linux-user/uname.c
> > @@ -52,9 +52,7 @@ const char *cpu_to_uname_machine(void *cpu_env)
> >      /* earliest emulated CPU is ARMv5TE; qemu can emulate the 1026, but not its
> >       * Jazelle support */
> >      return "armv5te" utsname_suffix;
> > -#elif defined(TARGET_X86_64)
> > -    return "x86-64";
> > -#elif defined(TARGET_I386)
> > +#elif defined(TARGET_I386) && !defined(TARGET_X86_64)
> >      /* see arch/x86/kernel/cpu/bugs.c: check_bugs(), 386, 486, 586, 686 */
> >      CPUState *cpu = ENV_GET_CPU((CPUX86State *)cpu_env);
> >      int family = object_property_get_int(OBJECT(cpu), "family", NULL);
> > --
> > 1.9.2
> >
> >