From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsXj9-0008DZ-Ht for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:29:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsXj3-00087M-Tz for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:29:07 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:47988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsXj3-000877-N7 for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:29:01 -0400 Received: by mail-wi0-f169.google.com with SMTP id hi2so9624782wib.0 for ; Thu, 05 Jun 2014 06:29:00 -0700 (PDT) Date: Thu, 5 Jun 2014 15:28:57 +0200 From: Stefan Hajnoczi Message-ID: <20140605132857.GA8759@stefanha-thinkpad.redhat.com> References: <1401960072-2363-1-git-send-email-cyliu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1401960072-2363-1-git-send-email-cyliu@suse.com> Subject: Re: [Qemu-devel] [PATCH v28 00/33] replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu Cc: qemu-devel@nongnu.org, stefanha@redhat.com On Thu, Jun 05, 2014 at 05:20:39PM +0800, Chunyan Liu wrote: > This patch series is to replace QEMUOptionParameter with QemuOpts, so that only > one Qemu Option structure is kept in QEMU code. > > --- > Changes to v27: > * rebase to git master (code has been updated in this part since v27 sent > so rebase to make the patch series work.) This series causes two qemu-iotests failures. For info on qemu-iotests: http://qemu-project.org/Documentation/QemuIoTests Luckily they look easy to fix, they are just differences in error messages. Please preserve error messages where possible, and otherwise just update the test .out file. When resolving these test failures, please make sure to keep bisectability by squashing the fix where the failure was introduced instead of adding new patches to the end of the series. 049 6s ... - output mismatch (see 049.out.bad) --- 049.out 2014-06-05 15:04:21.952358444 +0200 +++ 049.out.bad 2014-06-05 15:11:29.143000551 +0200 @@ -120,7 +120,7 @@ qemu-img create -f qcow2 -o size=foobar TEST_DIR/t.qcow2 qemu-img: Parameter 'size' expects a size -qemu-img: TEST_DIR/t.qcow2: Invalid options for file format 'qcow2' +qemu-img: TEST_DIR/t.qcow2: Invalid options for file format 'qcow2'. == Check correct interpretation of suffixes for cluster size == 061 7s ... - output mismatch (see 061.out.bad) --- 061.out 2014-06-05 15:04:21.952358444 +0200 +++ 061.out.bad 2014-06-05 15:12:08.024050567 +0200 @@ -281,7 +281,7 @@ qemu-img: Error while amending options: Invalid argument Unknown compatibility level 0.42. qemu-img: Error while amending options: Invalid argument -qemu-img: Invalid parameter 'foo' +Unknown option 'foo' qemu-img: Invalid options for file format 'qcow2' Changing the cluster size is not supported. qemu-img: Error while amending options: Operation not supported