Re: [Qemu-devel] [PATCH 0/2] help libvirt know what's up with qga

[Amit Shah <amit.shah@redhat.com>]

On (Thu) 29 May 2014 [21:36:39], Laszlo Ersek wrote:
> In this series I try to implement the ideas that (I believe) were
> suggested by Gerd and Amit in
> <https://bugzilla.redhat.com/show_bug.cgi?id=1080376>.
> 
> When the guest agent exits or dies (disconnects from the virtio-serial
> port), the backend (eg. a host-side unix domain socket) doesn't (in
> general, can't) reflect it. This lack of info tends to trip up libvirt
> in some cases, waiting indefinitely for an agent that doesn't exist.
> 
> The series adds two monitor events that report about virtio-serial ports
> being opened and closed (for online notification), and extends the
> "query-chardev" QMP command's return type with a "frontend_open" bool
> (for querying at late libvirt startup).
> 
> Admittedly, these two don't report on the same level (frontend vs.
> backend), but the association is under libvirt's control, so it should
> be fine, and it helps keep the series non-intrusive. (Also known as, "I
> have a fleeting chance implementing it, having authored neither chardev
> nor virtio-serial".)

Hey, that's alright :-)

I don't have a problem with the series, and please don't let me block
it -- I already see you and Eric had a nice discussion, and I don't
feel strongly about anything there -- so for things where you're
waiting on me, please pick what both of you think is best.

Thanks,
 
		Amit