From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsqgB-0003cc-KK for qemu-devel@nongnu.org; Fri, 06 Jun 2014 05:43:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wsqg5-0008PR-FW for qemu-devel@nongnu.org; Fri, 06 Jun 2014 05:43:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsqg5-0008P6-7G for qemu-devel@nongnu.org; Fri, 06 Jun 2014 05:43:13 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s569hCIr017731 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 6 Jun 2014 05:43:12 -0400 Date: Fri, 6 Jun 2014 15:13:05 +0530 From: Amit Shah Message-ID: <20140606094305.GA6708@grmbl.mre> References: <1401392201-29988-1-git-send-email-lersek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1401392201-29988-1-git-send-email-lersek@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] help libvirt know what's up with qga List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: mprivozn@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On (Thu) 29 May 2014 [21:36:39], Laszlo Ersek wrote: > In this series I try to implement the ideas that (I believe) were > suggested by Gerd and Amit in > . > > When the guest agent exits or dies (disconnects from the virtio-serial > port), the backend (eg. a host-side unix domain socket) doesn't (in > general, can't) reflect it. This lack of info tends to trip up libvirt > in some cases, waiting indefinitely for an agent that doesn't exist. > > The series adds two monitor events that report about virtio-serial ports > being opened and closed (for online notification), and extends the > "query-chardev" QMP command's return type with a "frontend_open" bool > (for querying at late libvirt startup). > > Admittedly, these two don't report on the same level (frontend vs. > backend), but the association is under libvirt's control, so it should > be fine, and it helps keep the series non-intrusive. (Also known as, "I > have a fleeting chance implementing it, having authored neither chardev > nor virtio-serial".) Hey, that's alright :-) I don't have a problem with the series, and please don't let me block it -- I already see you and Eric had a nice discussion, and I don't feel strongly about anything there -- so for things where you're waiting on me, please pick what both of you think is best. Thanks, Amit