From: Amit Shah <amit.shah@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: pbonzini@redhat.com, quintela@redhat.com,
Peter Lieven <pl@kamp.de>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RESEND] migration: catch unknown flags in ram_load
Date: Fri, 6 Jun 2014 17:55:36 +0530 [thread overview]
Message-ID: <20140606122535.GA27148@grmbl.mre> (raw)
In-Reply-To: <20140603172714.GH3017@work-vm>
On (Tue) 03 Jun 2014 [18:27:15], Dr. David Alan Gilbert wrote:
> * Peter Lieven (pl@kamp.de) wrote:
> > if a saved vm has unknown flags in the memory data qemu
> > currently simply ignores this flag and continues which
> > yields in an unpredictable result.
> >
> > this patch catches all unknown flags and
> > aborts the loading of the vm.
>
> Yes, I think that's quite nice - the only thing I'd add which would help
> a little is an error_report() in the case where you have invalid flags
> to let you know that's the reason for the EINVAL.
Agreed.
Amit
next prev parent reply other threads:[~2014-06-06 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401485884-25500-1-git-send-email-pl@kamp.de>
2014-06-03 17:27 ` [Qemu-devel] [PATCH RESEND] migration: catch unknown flags in ram_load Dr. David Alan Gilbert
2014-06-06 12:25 ` Amit Shah [this message]
2014-06-10 7:31 ` Amit Shah
2014-06-10 8:04 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606122535.GA27148@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).