From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/9] virtio-blk: Move VirtIOBlockReq to header
Date: Fri, 6 Jun 2014 15:08:16 +0200 [thread overview]
Message-ID: <20140606130816.GD14322@stefanha-thinkpad> (raw)
In-Reply-To: <1402019610-2985-2-git-send-email-famz@redhat.com>
On Fri, Jun 06, 2014 at 09:53:22AM +0800, Fam Zheng wrote:
> diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h
> index 4bc9b54..6fc43f1 100644
> --- a/include/hw/virtio/virtio-blk.h
> +++ b/include/hw/virtio/virtio-blk.h
> @@ -17,6 +17,7 @@
> #include "hw/virtio/virtio.h"
> #include "hw/block/block.h"
> #include "sysemu/iothread.h"
> +#include "include/block/block.h"
Why not #include "block/block.h"? The other includes don't explicitly
use the include/ prefix either.
next prev parent reply other threads:[~2014-06-06 13:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 1:53 [Qemu-devel] [PATCH v3 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq Fam Zheng
2014-06-06 1:53 ` [Qemu-devel] [PATCH v3 1/9] virtio-blk: Move VirtIOBlockReq to header Fam Zheng
2014-06-06 13:08 ` Stefan Hajnoczi [this message]
2014-06-06 1:53 ` [Qemu-devel] [PATCH v3 2/9] virtio-blk: Convert VirtIOBlockReq.elem to pointer Fam Zheng
2014-06-06 13:06 ` Stefan Hajnoczi
2014-06-06 1:53 ` [Qemu-devel] [PATCH v3 3/9] virtio-blk: Drop bounce buffer from dataplane code Fam Zheng
2014-06-06 1:53 ` [Qemu-devel] [PATCH v3 4/9] virtio-blk: Drop VirtIOBlockRequest.read Fam Zheng
2014-06-06 1:53 ` [Qemu-devel] [PATCH v3 5/9] virtio-blk: Replace VirtIOBlockRequest with VirtIOBlockReq Fam Zheng
2014-06-06 1:53 ` [Qemu-devel] [PATCH v3 6/9] virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr Fam Zheng
2014-06-06 13:05 ` Stefan Hajnoczi
2014-06-06 1:53 ` [Qemu-devel] [PATCH v3 7/9] virtio-blk: Convert VirtIOBlockReq.out to structrue Fam Zheng
2014-06-06 1:53 ` [Qemu-devel] [PATCH v3 8/9] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code Fam Zheng
2014-06-06 1:53 ` [Qemu-devel] [PATCH v3 9/9] virtio-blk: Fix and clean up the in_sg and out_sg check Fam Zheng
2014-06-06 13:16 ` Stefan Hajnoczi
2014-06-06 13:18 ` Paolo Bonzini
2014-06-06 6:53 ` [Qemu-devel] [PATCH v3 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq Paolo Bonzini
2014-06-06 13:17 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606130816.GD14322@stefanha-thinkpad \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).