From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53193)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Wsu1K-0001Dm-Kj
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 09:17:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Wsu1D-00079Q-Qk
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 09:17:22 -0400
Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:48310)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Wsu1D-000793-JP
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 09:17:15 -0400
Received: by mail-wi0-f170.google.com with SMTP id bs8so993189wib.5
	for <qemu-devel@nongnu.org>; Fri, 06 Jun 2014 06:17:14 -0700 (PDT)
Date: Fri, 6 Jun 2014 15:17:12 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140606131712.GF14322@stefanha-thinkpad>
References: <1402019610-2985-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1402019610-2985-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/9] virtio-blk: Converge
 VirtIOBlockRequest into VirtIOBlockReq
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Fri, Jun 06, 2014 at 09:53:21AM +0800, Fam Zheng wrote:
> This unifies the request structure used by dataplane and non-dataplane code,
> while dropping unnessary fields for bounce buffer and read flag.
> 
> Applies on top of Stefan's block tree.
> 
> v3: Address Paolo's comments:
> 
> [06/09] virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr
>         Add assertion and comments on inhdr.
>         Fix the offset and iov_discard_back.
> 
> [08/09] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code
>         Allocate req in process_request.
> 
> [09/09] virtio-blk: Fix and clean up the in_sg and out_sg check
>         New.
> 
> 
> 
> Fam Zheng (9):
>   virtio-blk: Move VirtIOBlockReq to header
>   virtio-blk: Convert VirtIOBlockReq.elem to pointer
>   virtio-blk: Drop bounce buffer from dataplane code
>   virtio-blk: Drop VirtIOBlockRequest.read
>   virtio-blk: Replace VirtIOBlockRequest with VirtIOBlockReq
>   virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr
>   virtio-blk: Convert VirtIOBlockReq.out to structrue
>   virtio-blk: Fill in VirtIOBlockReq.out in dataplane code
>   virtio-blk: Fix and clean up the in_sg and out_sg check
> 
>  hw/block/dataplane/virtio-blk.c | 167 +++++++++++++---------------------------
>  hw/block/virtio-blk.c           | 113 ++++++++++++++-------------
>  include/hw/virtio/virtio-blk.h  |  11 +++
>  3 files changed, 124 insertions(+), 167 deletions(-)

Looks pretty good, just left a few minor comments.