From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsutI-0000xT-PA for qemu-devel@nongnu.org; Fri, 06 Jun 2014 10:13:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsutD-00024w-Mj for qemu-devel@nongnu.org; Fri, 06 Jun 2014 10:13:08 -0400 Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:46343 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsutD-00024s-H0 for qemu-devel@nongnu.org; Fri, 06 Jun 2014 10:13:03 -0400 Date: Fri, 6 Jun 2014 16:13:02 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140606141300.GD16494@irqsave.net> References: <1402059060-17544-1-git-send-email-armbru@redhat.com> <1402059060-17544-4-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1402059060-17544-4-git-send-email-armbru@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/3] block/qapi: Give some functions internal linkage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com The Friday 06 Jun 2014 =E0 14:51:00 (+0200), Markus Armbruster wrote : > Signed-off-by: Markus Armbruster > --- > block/qapi.c | 13 ++++++------- > include/block/qapi.h | 7 ------- > 2 files changed, 6 insertions(+), 14 deletions(-) >=20 > diff --git a/block/qapi.c b/block/qapi.c > index 97e1641..f420e9a 100644 > --- a/block/qapi.c > +++ b/block/qapi.c > @@ -89,9 +89,9 @@ BlockDeviceInfo *bdrv_block_device_info(BlockDriverSt= ate *bs) > * information, or NULL because there are no snapshots. Returns -errn= o on > * error, with *p_list untouched. > */ > -int bdrv_query_snapshot_info_list(BlockDriverState *bs, > - SnapshotInfoList **p_list, > - Error **errp) > +static int bdrv_query_snapshot_info_list(BlockDriverState *bs, > + SnapshotInfoList **p_list, > + Error **errp) > { > int i, sn_count; > QEMUSnapshotInfo *sn_tab =3D NULL; > @@ -236,9 +236,8 @@ void bdrv_query_image_info(BlockDriverState *bs, > } > =20 > /* @p_info will be set only on success. */ > -void bdrv_query_info(BlockDriverState *bs, > - BlockInfo **p_info, > - Error **errp) > +static void bdrv_query_info(BlockDriverState *bs, BlockInfo **p_info, > + Error **errp) > { > BlockInfo *info =3D g_malloc0(sizeof(*info)); > BlockDriverState *bs0; > @@ -293,7 +292,7 @@ void bdrv_query_info(BlockDriverState *bs, > qapi_free_BlockInfo(info); > } > =20 > -BlockStats *bdrv_query_stats(const BlockDriverState *bs) > +static BlockStats *bdrv_query_stats(const BlockDriverState *bs) > { > BlockStats *s; > =20 > diff --git a/include/block/qapi.h b/include/block/qapi.h > index e92c00d..6672179 100644 > --- a/include/block/qapi.h > +++ b/include/block/qapi.h > @@ -30,16 +30,9 @@ > #include "block/snapshot.h" > =20 > BlockDeviceInfo *bdrv_block_device_info(BlockDriverState *bs); > -int bdrv_query_snapshot_info_list(BlockDriverState *bs, > - SnapshotInfoList **p_list, > - Error **errp); > void bdrv_query_image_info(BlockDriverState *bs, > ImageInfo **p_info, > Error **errp); > -void bdrv_query_info(BlockDriverState *bs, > - BlockInfo **p_info, > - Error **errp); > -BlockStats *bdrv_query_stats(const BlockDriverState *bs); > =20 > void bdrv_snapshot_dump(fprintf_function func_fprintf, void *f, > QEMUSnapshotInfo *sn); > --=20 > 1.9.3 >=20 >=20 Reviewed-by: Benoit Canet