From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45412)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Wta29-00017Y-JF
	for qemu-devel@nongnu.org; Sun, 08 Jun 2014 06:09:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Wta24-0006fu-Vm
	for qemu-devel@nongnu.org; Sun, 08 Jun 2014 06:09:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12224)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Wta24-0006fo-Mb
	for qemu-devel@nongnu.org; Sun, 08 Jun 2014 06:08:56 -0400
Date: Sun, 8 Jun 2014 13:09:20 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140608100920.GB21677@redhat.com>
References: <cover.1400049817.git.hutao@cn.fujitsu.com>
	<85a59c76eaa5acb5e7dec4de44067e87faf5fd90.1400049817.git.hutao@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <85a59c76eaa5acb5e7dec4de44067e87faf5fd90.1400049817.git.hutao@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v3.2 06/31] man: improve -numa doc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On Wed, May 14, 2014 at 05:43:10PM +0800, Hu Tao wrote:
> From: Luiz Capitulino <lcapitulino@redhat.com>
> 
> The -numa option documentation in qemu's manpage lacks the command-line
> options and some information regarding how it relates to options -m and
> -smp. This commit fills in the missing text.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  qemu-options.hx | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 781af14..c676397 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -97,10 +97,14 @@ ETEXI
>  DEF("numa", HAS_ARG, QEMU_OPTION_numa,
>      "-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]\n", QEMU_ARCH_ALL)
>  STEXI
> -@item -numa @var{opts}
> +@item -numa node[,mem=@var{size}][,cpus=@var{cpu[-cpu]}][,nodeid=@var{node}]
>  @findex -numa
> -Simulate a multi node NUMA system. If mem and cpus are omitted, resources
> -are split equally.
> +Simulate a multi node NUMA system. If @samp{mem}
> +and @samp{cpus} are omitted, resources are split equally. Also, note
> +that the -@option{numa} option doesn't allocate any of the specified
> +resources. That is, it just assigns existing resources to NUMA nodes. This
> +means that one still has to use the @option{-m}, @option{-smp} options
> +to respectively allocate RAM and vCPUs.

to allocate RAM and VCPUs respectively.

>  ETEXI
>  
>  DEF("add-fd", HAS_ARG, QEMU_OPTION_add_fd,
> -- 
> 1.8.5.2.229.g4448466
>