From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47890)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WtxHs-0002HZ-TI
	for qemu-devel@nongnu.org; Mon, 09 Jun 2014 06:58:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WtxHo-0002pV-Ad
	for qemu-devel@nongnu.org; Mon, 09 Jun 2014 06:58:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40985)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WtxHo-0002pL-0g
	for qemu-devel@nongnu.org; Mon, 09 Jun 2014 06:58:44 -0400
Date: Mon, 9 Jun 2014 13:59:04 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140609105904.GA4130@redhat.com>
References: <cover.1402299637.git.hutao@cn.fujitsu.com>
	<558890f22dfa66b5818f9795b27ea712b866409b.1402299637.git.hutao@cn.fujitsu.com>
	<CAFEAcA_5Bvv9oDcWh7E1F0Ks4=yCopBidix_n17sOa7vQwwMMQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_5Bvv9oDcWh7E1F0Ks4=yCopBidix_n17sOa7vQwwMMQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v4 24/29] Introduce signed range.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Eduardo Habkost <ehabkost@redhat.com>, Yasunori Goto <y-goto@jp.fujitsu.com>, Hu Tao <hutao@cn.fujitsu.com>, QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>

On Mon, Jun 09, 2014 at 11:42:14AM +0100, Peter Maydell wrote:
> On 9 June 2014 11:25, Hu Tao <hutao@cn.fujitsu.com> wrote:
> > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> > ---
> >  include/qemu/range.h | 124 +++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 124 insertions(+)
> >
> > diff --git a/include/qemu/range.h b/include/qemu/range.h
> > index aae9720..8879f8a 100644
> > --- a/include/qemu/range.h
> > +++ b/include/qemu/range.h
> > @@ -3,6 +3,7 @@
> >
> >  #include <inttypes.h>
> >  #include <qemu/typedefs.h>
> > +#include "qemu/queue.h"
> >
> >  /*
> >   * Operations on 64 bit address ranges.
> > @@ -60,4 +61,127 @@ static inline int ranges_overlap(uint64_t first1, uint64_t len1,
> >      return !(last2 < first1 || last1 < first2);
> >  }
> >
> > +typedef struct SignedRangeList SignedRangeList;
> > +
> > +typedef struct SignedRange {
> > +    int64_t start;
> > +    int64_t length;
> > +
> > +    QTAILQ_ENTRY(SignedRange) entry;
> > +} SignedRange;
> > +
> > +QTAILQ_HEAD(SignedRangeList, SignedRange);
> 
> This seems to be missing documentation about what the
> semantics are and why we need it as well as the standard
> Range. For instance, what does a SignedRange with a
> negative length mean?
> 
> thanks
> -- PMM


Yes I also don't care for list macros being mixed in with structure.

Also, numa surely uses positive numbers? why do you want
signed values?

-- 
MST