Re: [Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]

On Fri, Jun 06, 2014 at 10:33:49PM +0800, Amos Kong wrote:
> It's worth to add a hotplug test to qtest, but without
> cooperation of guest OS, new devices can't be initialized
> by guest, and hot-unplug doesn't work.
> 
> However, the new test can cover some part of code of
> hotplug/unplug.
> 
> I will write another subtest to test hotplug with pci support.
> 
> V2: move qmp_exec_hmp_cmd() to libqtest.c
>     excape hmp cmd (stefanha)
>     use qmp_exec_hmp_cmd() in blockdev-test
> V3: use vp_list to format string, free escaped string
> V4: free escaped string by g_free()
> 
> Amos Kong (4):
>   virtio-blk-test.c: change pci_nop() to virtblk_init()
>   qtest: introduce qmp_exec_hmp_cmd()
>   virtio-blk-test.c: add hotplug subtest
>   qtest: use qmp_exec_hmp_cmd() in blockdev-test
> 
>  tests/blockdev-test.c   | 23 ++---------------------
>  tests/libqtest.c        | 26 ++++++++++++++++++++++++++
>  tests/libqtest.h        |  9 +++++++++
>  tests/virtio-blk-test.c | 44 +++++++++++++++++++++++++++++++++++++-------
>  4 files changed, 74 insertions(+), 28 deletions(-)
> 
> -- 
> 1.9.3
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]