From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtzXW-0005Xg-4l for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:23:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WtzXK-0004DY-Ul for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:23:06 -0400 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:34250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtzXK-0004D8-NC for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:22:54 -0400 Received: by mail-wg0-f50.google.com with SMTP id x13so1818959wgg.21 for ; Mon, 09 Jun 2014 06:22:53 -0700 (PDT) Date: Mon, 9 Jun 2014 15:22:51 +0200 From: Stefan Hajnoczi Message-ID: <20140609132251.GC19546@stefanha-thinkpad.redhat.com> References: <1402065233-31894-1-git-send-email-akong@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8X7/QrJGcKSMr1RN" Content-Disposition: inline In-Reply-To: <1402065233-31894-1-git-send-email-akong@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: arei.gonglei@huawei.com, qemu-devel@nongnu.org, afaerber@suse.de --8X7/QrJGcKSMr1RN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 06, 2014 at 10:33:49PM +0800, Amos Kong wrote: > It's worth to add a hotplug test to qtest, but without > cooperation of guest OS, new devices can't be initialized > by guest, and hot-unplug doesn't work. >=20 > However, the new test can cover some part of code of > hotplug/unplug. >=20 > I will write another subtest to test hotplug with pci support. >=20 > V2: move qmp_exec_hmp_cmd() to libqtest.c > excape hmp cmd (stefanha) > use qmp_exec_hmp_cmd() in blockdev-test > V3: use vp_list to format string, free escaped string > V4: free escaped string by g_free() >=20 > Amos Kong (4): > virtio-blk-test.c: change pci_nop() to virtblk_init() > qtest: introduce qmp_exec_hmp_cmd() > virtio-blk-test.c: add hotplug subtest > qtest: use qmp_exec_hmp_cmd() in blockdev-test >=20 > tests/blockdev-test.c | 23 ++--------------------- > tests/libqtest.c | 26 ++++++++++++++++++++++++++ > tests/libqtest.h | 9 +++++++++ > tests/virtio-blk-test.c | 44 +++++++++++++++++++++++++++++++++++++------- > 4 files changed, 74 insertions(+), 28 deletions(-) >=20 > --=20 > 1.9.3 >=20 Reviewed-by: Stefan Hajnoczi --8X7/QrJGcKSMr1RN Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTlbUrAAoJEJykq7OBq3PIFl0IAKIRVw3x7qeupvrQLLCs58hJ TRCtb5o4Nx0fEyR5fW1pkArrPn4acIsrqlR21qontOq2qRm3cO7sUngjnZ8OuRXN HfVLjwLv/vL4xBJ1rbKZSOLS9O7cZ59V5CkttbW0kpi5ZTATJztii1mfLNz+aswK eAs5R2OTG7CB597pdr7Ae+ahV4hloxySxj8hMGPQJ7UAHc6yifVlcZM2ng2MXZY2 vfZmjiq/iEcCrZE6NrhYGCFgAQubQrWa2IM21mJN2SxJkFBXebCFdpjo3EIZEWQo mE4KNA47C7b+A9h8APZLmnomQXALj0OlrO0/ZK2hARdg0S5jq77RmkGPHgFtJdg= =1uaA -----END PGP SIGNATURE----- --8X7/QrJGcKSMr1RN--