From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wtzfh-00018B-CT for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:31:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wtzfb-00074l-Tx for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:31:33 -0400 Received: from mail-wg0-x22b.google.com ([2a00:1450:400c:c00::22b]:41735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wtzfb-00074g-JQ for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:31:27 -0400 Received: by mail-wg0-f43.google.com with SMTP id b13so1089795wgh.14 for ; Mon, 09 Jun 2014 06:31:26 -0700 (PDT) Date: Mon, 9 Jun 2014 15:31:23 +0200 From: Stefan Hajnoczi Message-ID: <20140609133123.GF19546@stefanha-thinkpad.redhat.com> References: <1401960072-2363-1-git-send-email-cyliu@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="udcq9yAoWb9A4FsZ" Content-Disposition: inline In-Reply-To: <1401960072-2363-1-git-send-email-cyliu@suse.com> Subject: Re: [Qemu-devel] [PATCH v28 00/33] replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu Cc: qemu-devel@nongnu.org, stefanha@redhat.com --udcq9yAoWb9A4FsZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 05, 2014 at 05:20:39PM +0800, Chunyan Liu wrote: > This patch series is to replace QEMUOptionParameter with QemuOpts, so tha= t only > one Qemu Option structure is kept in QEMU code. >=20 > --- > Changes to v27: > * rebase to git master (code has been updated in this part since v27 se= nt > so rebase to make the patch series work.) >=20 > All patches are also available from: > https://github.com/chunyanliu/qemu/commits/QemuOpts >=20 >=20 > Chunyan Liu (33): > QemuOpts: move find_desc_by_name ahead for later calling > QemuOpts: repurpose qemu_opts_print to replace > print_option_parameters > QemuOpts: add def_value_str to QemuOptDesc > qapi: output def_value_str when query command line options > QemuOpts: change opt->name|str from (const char *) to (char *) > QemuOpts: move qemu_opt_del ahead for later calling > QemuOpts: add qemu_opt_get_*_del functions for replace work > QemuOpts: add qemu_opts_print_help to replace print_option_help > QemuOpts: add conversion between QEMUOptionParameter to QemuOpts > QemuOpts: add qemu_opts_append to replace append_option_parameters > QemuOpts: check NULL input for qemu_opts_del > change block layer to support both QemuOpts and QEMUOptionParamter > vvfat.c: handle cross_driver's create_options and create_opts > cow.c: replace QEMUOptionParameter with QemuOpts > gluster.c: replace QEMUOptionParameter with QemuOpts > iscsi.c: replace QEMUOptionParameter with QemuOpts > nfs.c: replace QEMUOptionParameter with QemuOpts > qcow.c: replace QEMUOptionParameter with QemuOpts > QemuOpts: export qemu_opt_find > qcow2.c: replace QEMUOptionParameter with QemuOpts > qed.c: replace QEMUOptionParameter with QemuOpts > raw-posix.c: replace QEMUOptionParameter with QemuOpts > raw-win32.c: replace QEMUOptionParameter with QemuOpts > raw_bsd.c: replace QEMUOptionParameter with QemuOpts > rbd.c: replace QEMUOptionParameter with QemuOpts > sheepdog.c: replace QEMUOptionParameter with QemuOpts > ssh.c: replace QEMUOptionParameter with QemuOpts > vdi.c: replace QEMUOptionParameter with QemuOpts > vhdx.c: replace QEMUOptionParameter with QemuOpts > vmdk.c: replace QEMUOptionParameter with QemuOpts > vpc.c: replace QEMUOptionParameter with QemuOpts > cleanup QEMUOptionParameter > QemuOpts: cleanup tmp 'allocated' member from QemuOptsList >=20 > block.c | 99 ++++---- > block/cow.c | 52 ++-- > block/gluster.c | 73 +++--- > block/iscsi.c | 32 ++- > block/nfs.c | 10 +- > block/qcow.c | 72 +++--- > block/qcow2.c | 259 ++++++++++---------- > block/qed.c | 112 +++++---- > block/qed.h | 3 +- > block/raw-posix.c | 55 ++--- > block/raw-win32.c | 38 +-- > block/raw_bsd.c | 25 +- > block/rbd.c | 61 +++-- > block/sheepdog.c | 105 ++++---- > block/ssh.c | 30 ++- > block/vdi.c | 71 +++--- > block/vhdx.c | 97 ++++---- > block/vhdx.h | 1 + > block/vmdk.c | 121 +++++----- > block/vpc.c | 60 ++--- > block/vvfat.c | 14 +- > include/block/block.h | 7 +- > include/block/block_int.h | 9 +- > include/qemu/option.h | 53 +--- > include/qemu/option_int.h | 4 +- > qapi-schema.json | 5 +- > qapi/opts-visitor.c | 10 +- > qemu-img.c | 91 ++++--- > qmp-commands.hx | 2 + > tests/qemu-iotests/049.out | 2 +- > tests/qemu-iotests/061.out | 2 +- > util/qemu-config.c | 4 + > util/qemu-option.c | 590 ++++++++++++++++++++-------------------= ------ > 33 files changed, 1037 insertions(+), 1132 deletions(-) >=20 > --=20 > 1.7.12.4 >=20 >=20 Reviewed-by: Stefan Hajnoczi --udcq9yAoWb9A4FsZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTlbcrAAoJEJykq7OBq3PI3K4IAJw2kgeapQ2bNDGhPbEPngi6 WcSvKHEzjzZJX9cRnP6T/WH5V2zNNY70jan5OROkRuRAm4f8AFjP/M/XGszx6N6T lllDpI+oRmMk9+cpnEupiatnqZonyQGjbLvD3T/oVSpJNHbn8xmWHqmqItStEQz/ bWMM6jBs9qNE9t9Q+IGveA212A4Cxw39x6L8VGLYKYWkG6RkFMtGcux/QVcxgtuT FpC6CffBkE273BeIm35aKo0qSVvyLX09P0gp3MbRimiu4LqKNrSyNIL3LkaTH+iO jgYeS97f1lUzjMkcOXk84E2gWLkK9psh0VyQ1AZljlRQbS+v6bXIVDC2iX273A0= =iWss -----END PGP SIGNATURE----- --udcq9yAoWb9A4FsZ--