From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56904)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WtzhL-0003EW-1i
	for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:33:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WtzhD-0007cG-Je
	for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:33:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53475)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WtzhD-0007c6-8y
	for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:33:07 -0400
Date: Mon, 9 Jun 2014 15:32:57 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20140609153257.49d4460f@thinkpad>
In-Reply-To: <5395AF7F.7000403@redhat.com>
References: <cover.1402299637.git.hutao@cn.fujitsu.com>
	<66e17e32ccb10ca0ae262103fcf170b84511c3f8.1402299637.git.hutao@cn.fujitsu.com>
	<20140609143622.44fa7006@thinkpad> <5395AF7F.7000403@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Hu Tao <hutao@cn.fujitsu.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>, Yasunori Goto <y-goto@jp.fujitsu.com>

On Mon, 09 Jun 2014 14:58:39 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 09/06/2014 14:36, Igor Mammedov ha scritto:
> >> > +{ 'type': 'Memdev',
> >> > +  'data': {
> >> > +    'size':       'size',
> >> > +    'merge':      'bool',
> >> > +    'dump':       'bool',
> >> > +    'prealloc':   'bool',
> >> > +    'host-nodes': ['uint16'],
> >> > +    'policy':     'HostMemPolicy' }}
> >> > +
> >> > +##
> >> > +# @query-memdev:
> >> > +#
> >> > +# Returns information for all memory devices.
> >> > +#
> >> > +# Returns: a list of @Memdev.
> >> > +#
> >> > +# Since: 2.1
> >> > +##
> >> > +{ 'command': 'query-memdev', 'returns': ['Memdev'] }
> > Could we make it union, that returns MemdevRam + MemdevFile
> >
> > MemdevFile will have additional file-only specific properties.
> >
> 
> Which are the file-only properties (in the current definition of Memdev)?
in current none, but for file backend exposing 'path' property might be useful
alternatively instead of union we could add 'type' and optional 'path' fields
to Memdev

> 
> Paolo
> 


-- 
Regards,
  Igor