From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wu5on-00009I-Bi for qemu-devel@nongnu.org; Mon, 09 Jun 2014 16:05:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wu5oh-0006xW-63 for qemu-devel@nongnu.org; Mon, 09 Jun 2014 16:05:21 -0400 Date: Mon, 9 Jun 2014 16:04:26 -0400 From: Luiz Capitulino Message-ID: <20140609160426.63250974@redhat.com> In-Reply-To: <1401480140-18653-2-git-send-email-ehabkost@redhat.com> References: <1401480140-18653-1-git-send-email-ehabkost@redhat.com> <1401480140-18653-2-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] rng-random: NULL check not needed before g_free() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-trivial@nongnu.org, Marcel Apfelbaum , qemu-devel@nongnu.org, Anthony Liguori , Andreas =?UTF-8?B?RsOkcmJlcg==?= On Fri, 30 May 2014 17:02:18 -0300 Eduardo Habkost wrote: > g_free() is NULL-safe. > > Signed-off-by: Eduardo Habkost This one should to go through qemu-trivial (CCed). > --- > Cc: Anthony Liguori > Cc: Luiz Capitulino > --- > backends/rng-random.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/backends/rng-random.c b/backends/rng-random.c > index 136499d..601d9dc 100644 > --- a/backends/rng-random.c > +++ b/backends/rng-random.c > @@ -106,10 +106,7 @@ static void rng_random_set_filename(Object *obj, const char *filename, > return; > } > > - if (s->filename) { > - g_free(s->filename); > - } > - > + g_free(s->filename); > s->filename = g_strdup(filename); > } >