[Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration

[Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration

[arei.gonglei]

From: Gonglei <arei.gonglei@huawei.com>

If the networking break or there's something wrong with rdma
device(ib0 with no IP) during rdma migration, the main_loop of
qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
to fix this bug.

Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
---
v2:
 - add reviewed-by.

 migration-rdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/migration-rdma.c b/migration-rdma.c
index eeb4302..f60749b 100644
--- a/migration-rdma.c
+++ b/migration-rdma.c
@@ -949,6 +949,7 @@ route:
         ERROR(errp, "result not equal to event_addr_resolved %s",
                 rdma_event_str(cm_event->event));
         perror("rdma_resolve_addr");
+        rdma_ack_cm_event(cm_event);
         ret = -EINVAL;
         goto err_resolve_get_addr;
     }
-- 
1.7.12.4

Re: [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration

[Amit Shah]

On (Tue) 13 May 2014 [20:25:38], arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> If the networking break or there's something wrong with rdma
> device(ib0 with no IP) during rdma migration, the main_loop of
> qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
> to fix this bug.
> 
> Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>

Reviewed-by: Amit Shah <amit.shah@redhat.com>

		Amit

Re: [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration

[Gonglei (Arei)]

> -----Original Message-----
> From: Amit Shah [mailto:amit.shah@redhat.com]
> Sent: Tuesday, June 10, 2014 3:20 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; yamahata@private.email.ne.jp; Huangweidong
> (C); quintela@redhat.com; mjt@tls.msk.ru; owasserm@redhat.com;
> mrhines@us.ibm.com; Moyuxiang; pbonzini@redhat.com
> Subject: Re: [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration
> 
> On (Tue) 13 May 2014 [20:25:38], arei.gonglei@huawei.com wrote:
> > From: Gonglei <arei.gonglei@huawei.com>
> >
> > If the networking break or there's something wrong with rdma
> > device(ib0 with no IP) during rdma migration, the main_loop of
> > qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
> > to fix this bug.
> >
> > Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
> > Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> > Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
> 
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
> 
> 		Amit
Thanks.

Juan, do you plan to apply this patch?

Best regards,
-Gonglei

Re: [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration

[Juan Quintela]

<arei.gonglei@huawei.com> wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> If the networking break or there's something wrong with rdma
> device(ib0 with no IP) during rdma migration, the main_loop of
> qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
> to fix this bug.
>
> Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
> ---
> v2:
>  - add reviewed-by.

Applied, thanks.